| Message ID | 1466416634-9798-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 20/06/16 12:57, Peter Maydell wrote: > Fix missing includes of qemu/log.h, which broke compilation with the > simple trace backend (the default backend pulls in log.h implicitly > via trace.h). > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org> Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org> Thanks, Sergey > --- > In particular, this broke travis builds. > --- > hw/intc/arm_gicv3_dist.c | 1 + > hw/intc/arm_gicv3_redist.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c > index b977ae5..3ea3dd0 100644 > --- a/hw/intc/arm_gicv3_dist.c > +++ b/hw/intc/arm_gicv3_dist.c > @@ -10,6 +10,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "trace.h" > #include "gicv3_internal.h" > > diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c > index 55c25e8..2f60096 100644 > --- a/hw/intc/arm_gicv3_redist.c > +++ b/hw/intc/arm_gicv3_redist.c > @@ -10,6 +10,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "trace.h" > #include "gicv3_internal.h" >
On 20 June 2016 at 11:22, Sergey Fedorov <sergey.fedorov@linaro.org> wrote: > On 20/06/16 12:57, Peter Maydell wrote: >> Fix missing includes of qemu/log.h, which broke compilation with the >> simple trace backend (the default backend pulls in log.h implicitly >> via trace.h). >> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > > Tested-by: Sergey Fedorov <sergey.fedorov@linaro.org> > Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org> Thanks. Applied to master as a build fix. -- PMM
diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c index b977ae5..3ea3dd0 100644 --- a/hw/intc/arm_gicv3_dist.c +++ b/hw/intc/arm_gicv3_dist.c @@ -10,6 +10,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "trace.h" #include "gicv3_internal.h" diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c index 55c25e8..2f60096 100644 --- a/hw/intc/arm_gicv3_redist.c +++ b/hw/intc/arm_gicv3_redist.c @@ -10,6 +10,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "trace.h" #include "gicv3_internal.h"
Fix missing includes of qemu/log.h, which broke compilation with the simple trace backend (the default backend pulls in log.h implicitly via trace.h). Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- In particular, this broke travis builds. --- hw/intc/arm_gicv3_dist.c | 1 + hw/intc/arm_gicv3_redist.c | 1 + 2 files changed, 2 insertions(+)