| Message ID | 1466406922-32663-1-git-send-email-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 61717571f2b55747e394f217b2fd519213433f88 |
| Delegated to: | Scott Wood |
| Headers | show |
On Mon, 2016-06-20 at 15:15 +0800, Peng Fan wrote: > Error info " > common/fb_nand.c: In function 'fb_nand_lookup': > common/fb_nand.c:65:3: error: 'mtd' undeclared (first use in this function) > *mtd = nand_info[dev->id->num]; > ^ > " > > Correct fb_nand_lookup parameter name to fix this issue. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Scott Wood <oss@buserror.net> > Cc: Tom Rini <trini@konsulko.com> > --- > common/fb_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I've already received and applied a patch for this. -Scott
Hi Scott, On Mon, Jun 20, 2016 at 03:17:11AM -0500, Scott Wood wrote: >On Mon, 2016-06-20 at 15:15 +0800, Peng Fan wrote: >> Error info " >> common/fb_nand.c: In function 'fb_nand_lookup': >> common/fb_nand.c:65:3: error: 'mtd' undeclared (first use in this function) >> *mtd = nand_info[dev->id->num]; >> ^ >> " >> >> Correct fb_nand_lookup parameter name to fix this issue. >> >> Signed-off-by: Peng Fan <peng.fan@nxp.com> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >> Cc: Scott Wood <oss@buserror.net> >> Cc: Tom Rini <trini@konsulko.com> >> --- >> common/fb_nand.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >I've already received and applied a patch for this. I worked this patch based on upstream tree and not checked your tree. Drop this patch, since there is already a fix. Thanks, Peng. > >-Scott >
diff --git a/common/fb_nand.c b/common/fb_nand.c index e55ea38..ae34f48 100644 --- a/common/fb_nand.c +++ b/common/fb_nand.c @@ -34,7 +34,7 @@ __weak int board_fastboot_write_partition_setup(char *name) } static int fb_nand_lookup(const char *partname, char *response, - struct mtd_info **nand, + struct mtd_info **mtd, struct part_info **part) { struct mtd_device *dev;
Error info " common/fb_nand.c: In function 'fb_nand_lookup': common/fb_nand.c:65:3: error: 'mtd' undeclared (first use in this function) *mtd = nand_info[dev->id->num]; ^ " Correct fb_nand_lookup parameter name to fix this issue. Signed-off-by: Peng Fan <peng.fan@nxp.com> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Scott Wood <oss@buserror.net> Cc: Tom Rini <trini@konsulko.com> --- common/fb_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)