| Message ID | 1466379196-12252-3-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 01a227dfc890c8e1b6412a7208fb178d9ac22691 |
| Delegated to: | Simon Glass |
| Headers | show |
On Mon, Jun 20, 2016 at 7:33 AM, Simon Glass <sjg@chromium.org> wrote: > The list is shrinking and we should avoid adding new things. Instead, a > proper driver should be created with driver model. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v3: > - Add new patch to request people avoid adding new compatible strings > > lib/fdtdec.c | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 19 June 2016 at 19:48, Bin Meng <bmeng.cn@gmail.com> wrote: > On Mon, Jun 20, 2016 at 7:33 AM, Simon Glass <sjg@chromium.org> wrote: >> The list is shrinking and we should avoid adding new things. Instead, a >> proper driver should be created with driver model. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> Changes in v3: >> - Add new patch to request people avoid adding new compatible strings >> >> lib/fdtdec.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-dm/next.
diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 59b75f0..668acca 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -19,6 +19,11 @@ DECLARE_GLOBAL_DATA_PTR; * Here are the type we know about. One day we might allow drivers to * register. For now we just put them here. The COMPAT macro allows us to * turn this into a sparse list later, and keeps the ID with the name. + * + * NOTE: This list is basically a TODO list for things that need to be + * converted to driver model. So don't add new things here unless there is a + * good reason why driver-model conversion is infeasible. Examples include + * things which are used before driver model is available. */ #define COMPAT(id, name) name static const char * const compat_names[COMPAT_COUNT] = {
The list is shrinking and we should avoid adding new things. Instead, a proper driver should be created with driver model. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v3: - Add new patch to request people avoid adding new compatible strings lib/fdtdec.c | 5 +++++ 1 file changed, 5 insertions(+)