| Message ID | 1466179394-4744-2-git-send-email-c.pinto@virtualopensystems.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote: > Signed-off-by: Christian Pinto <c.pinto@virtualopensystems.com> > --- > content.tex | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/content.tex b/content.tex > index d989d98..0d98926 100644 > --- a/content.tex > +++ b/content.tex > @@ -2990,6 +2990,8 @@ Device ID & Virtio Device \\ > \hline > 18 & Input device \\ > \hline > +19 & Signal Distribution Module \\ > +\hline Please use a higher number, 19 is already proposed for virtio-vsock: https://lists.oasis-open.org/archives/virtio-dev/201603/msg00042.html > @@ -5641,6 +5643,8 @@ descriptor for the \field{sense_len}, \field{residual}, > \field{status_qualifier}, \field{status}, \field{response} and > \field{sense} fields. > > +\input{virtio-sdm.tex} Please move this to the patch that adds virtio-sdm.tex. Each patch must be self-contained and build successfully.
Hello Stefan, On Thu, Jun 23, 2016 at 8:57 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote: > On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote: > > Signed-off-by: Christian Pinto <c.pinto@virtualopensystems.com> > > --- > > content.tex | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/content.tex b/content.tex > > index d989d98..0d98926 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -2990,6 +2990,8 @@ Device ID & Virtio Device \\ > > \hline > > 18 & Input device \\ > > \hline > > +19 & Signal Distribution Module \\ > > +\hline > > Please use a higher number, 19 is already proposed for virtio-vsock: > https://lists.oasis-open.org/archives/virtio-dev/201603/msg00042.html Thanks, I will use 20 then. > > > > @@ -5641,6 +5643,8 @@ descriptor for the \field{sense_len}, > \field{residual}, > > \field{status_qualifier}, \field{status}, \field{response} and > > \field{sense} fields. > > > > +\input{virtio-sdm.tex} > > Please move this to the patch that adds virtio-sdm.tex. Each patch must > be self-contained and build successfully. > Right, I will add this change to the patch adding the device specification text. Best, Christian
On Fri, 24 Jun 2016 14:45:29 +0200 Christian Pinto <c.pinto@virtualopensystems.com> wrote: > On Thu, Jun 23, 2016 at 8:57 PM, Stefan Hajnoczi <stefanha@redhat.com> > wrote: > > > On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote: > > > @@ -2990,6 +2990,8 @@ Device ID & Virtio Device \\ > > > \hline > > > 18 & Input device \\ > > > \hline > > > +19 & Signal Distribution Module \\ > > > +\hline > > > > Please use a higher number, 19 is already proposed for virtio-vsock: > > https://lists.oasis-open.org/archives/virtio-dev/201603/msg00042.html > > > Thanks, I will use 20 then. I think virtio-crypto already wants to use 20. We sadly have a bit of a backlog...
On Fri, Jun 24, 2016 at 3:04 PM, Cornelia Huck <cornelia.huck@de.ibm.com> wrote: > On Fri, 24 Jun 2016 14:45:29 +0200 > Christian Pinto <c.pinto@virtualopensystems.com> wrote: > > > On Thu, Jun 23, 2016 at 8:57 PM, Stefan Hajnoczi <stefanha@redhat.com> > > wrote: > > > > > On Fri, Jun 17, 2016 at 06:03:13PM +0200, Christian Pinto wrote: > > > > > @@ -2990,6 +2990,8 @@ Device ID & Virtio Device \\ > > > > \hline > > > > 18 & Input device \\ > > > > \hline > > > > +19 & Signal Distribution Module \\ > > > > +\hline > > > > > > Please use a higher number, 19 is already proposed for virtio-vsock: > > > https://lists.oasis-open.org/archives/virtio-dev/201603/msg00042.html > > > > > > Thanks, I will use 20 then. > > I think virtio-crypto already wants to use 20. We sadly have a bit of a > backlog... > Thanks Cornelia, I'll use another number. BTW, Is there a way to know which one is the first free device ID? I was not following virtio-dev before, so not aware of all the pending device specs. Thanks, Christian
diff --git a/content.tex b/content.tex index d989d98..0d98926 100644 --- a/content.tex +++ b/content.tex @@ -2990,6 +2990,8 @@ Device ID & Virtio Device \\ \hline 18 & Input device \\ \hline +19 & Signal Distribution Module \\ +\hline \end{tabular} Some of the devices above are unspecified by this document, @@ -5641,6 +5643,8 @@ descriptor for the \field{sense_len}, \field{residual}, \field{status_qualifier}, \field{status}, \field{response} and \field{sense} fields. +\input{virtio-sdm.tex} + \chapter{Reserved Feature Bits}\label{sec:Reserved Feature Bits} Currently there are three device-independent feature bits defined:
Signed-off-by: Christian Pinto <c.pinto@virtualopensystems.com> --- content.tex | 4 ++++ 1 file changed, 4 insertions(+)