diff mbox

[U-Boot,2/2] imx: ventana: default pci to disabled

Message ID 1466169626-11158-3-git-send-email-tharvey@gateworks.com
State Accepted
Commit f4416579d31d884305e383f7370ee2262c0f8a7d
Delegated to: Stefano Babic
Headers show

Commit Message

Tim Harvey June 17, 2016, 1:20 p.m. UTC
The IMX6 PCIe host controller does not have a proper reset and as such there
are several issues that can arise if PCI is enabled in the bootloader follwed
by Linux trying to re-configure LTSSM and/or toggling PERST# to the devices.

For now, the best approach seems to default to disabling PCI by defaulting
pciedisable=1. This can be overridden by the user if they need PCI in the
bootloader, for example:
 - GW552x needing ethernet access in bootloader
 - GW16082 expansion board needing a device-tree fixup for irq mapping

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 include/configs/gw_ventana.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic July 28, 2016, 10:29 a.m. UTC | #1
On 17/06/2016 15:20, Tim Harvey wrote:
> The IMX6 PCIe host controller does not have a proper reset and as such there
> are several issues that can arise if PCI is enabled in the bootloader follwed
> by Linux trying to re-configure LTSSM and/or toggling PERST# to the devices.
> 
> For now, the best approach seems to default to disabling PCI by defaulting
> pciedisable=1. This can be overridden by the user if they need PCI in the
> bootloader, for example:
>  - GW552x needing ethernet access in bootloader
>  - GW16082 expansion board needing a device-tree fixup for irq mapping
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  include/configs/gw_ventana.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> index 982ddba..4acfca6 100644
> --- a/include/configs/gw_ventana.h
> +++ b/include/configs/gw_ventana.h
> @@ -274,6 +274,7 @@
>  	"dio0:mode=gpio;dio1:mode=gpio;dio2:mode=gpio;dio3:mode=gpio\0" \
>  
>  #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
> +	"pcidisable=1\0" \
>  	"usb_pgood_delay=2000\0" \
>  	"console=ttymxc1\0" \
>  	"bootdevs=usb mmc sata flash\0" \
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
index 982ddba..4acfca6 100644
--- a/include/configs/gw_ventana.h
+++ b/include/configs/gw_ventana.h
@@ -274,6 +274,7 @@ 
 	"dio0:mode=gpio;dio1:mode=gpio;dio2:mode=gpio;dio3:mode=gpio\0" \
 
 #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
+	"pcidisable=1\0" \
 	"usb_pgood_delay=2000\0" \
 	"console=ttymxc1\0" \
 	"bootdevs=usb mmc sata flash\0" \