From patchwork Fri Sep 3 15:19:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marcin_Baczy=C5=84ski?= X-Patchwork-Id: 63692 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A470BB715A for ; Sat, 4 Sep 2010 01:19:18 +1000 (EST) Received: (qmail 11433 invoked by alias); 3 Sep 2010 15:19:17 -0000 Received: (qmail 11425 invoked by uid 22791); 3 Sep 2010 15:19:16 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 15:19:10 +0000 Received: by ewy7 with SMTP id 7so1246877ewy.20 for ; Fri, 03 Sep 2010 08:19:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.34.140 with SMTP id l12mr8863ebd.58.1283527148303; Fri, 03 Sep 2010 08:19:08 -0700 (PDT) Received: by 10.14.18.71 with HTTP; Fri, 3 Sep 2010 08:19:08 -0700 (PDT) In-Reply-To: References: <8739u6lwr1.fsf@gmail.com> Date: Fri, 3 Sep 2010 17:19:08 +0200 Message-ID: Subject: Re: [PATCH] Remove old #if 0-ed code From: =?UTF-8?Q?Marcin_Baczy=C5=84ski?= To: gcc-patches@gcc.gnu.org Cc: Diego Novillo Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org W dniu 3 września 2010 17:05 użytkownik Diego Novillo napisał: > On Sun, Aug 22, 2010 at 07:20, Marcin Baczyński wrote: >> This code was #if 0-ed over 12 years ago. >> >> 2010-08-22  Marcin Baczynski   >> >>        * dwarf2out.c (file scope): Remove garbage. >>        (gen_subprogram_die): Same. > > s/garbage/#if0'd code/ > > OK with that change. > > > Diego. > Fixed. Can someone commit this? I don't have SVN write access. Thanks. 2010-09-03 Marcin Baczynski * dwarf2out.c (file scope): Remove #if0'd code. (gen_subprogram_die): Same. Index: gcc/dwarf2out.c =================================================================== --- gcc/dwarf2out.c (wersja 163449) +++ gcc/dwarf2out.c (kopia robocza) @@ -6043,9 +6043,6 @@ static GTY ((param_is (struct vcall_insn /* Record whether the function being analyzed contains inlined functions. */ static int current_function_has_inlines; -#if 0 && defined (MIPS_DEBUGGING_INFO) -static int comp_unit_has_inlines; -#endif /* The last file entry emitted by maybe_emit_file(). */ static GTY(()) struct dwarf_file_data * last_emitted_file; @@ -18960,18 +18957,6 @@ gen_subprogram_die (tree decl, dw_die_re current_function_has_inlines = 0; decls_for_scope (outer_scope, subr_die, 0); - -#if 0 && defined (MIPS_DEBUGGING_INFO) - if (current_function_has_inlines) - { - add_AT_flag (subr_die, DW_AT_MIPS_has_inlines, 1); - if (! comp_unit_has_inlines) - { - add_AT_flag (comp_unit_die, DW_AT_MIPS_has_inlines, 1); - comp_unit_has_inlines = 1; - } - } -#endif } /* Add the calling convention attribute if requested. */ add_calling_convention_attribute (subr_die, decl);