Patchwork hibernation hangs with ATA errors (lockup_detector bug)

login
register
mail settings
Submitter Jiri Slaby
Date Sept. 3, 2010, 8:35 a.m.
Message ID <4C80B338.6020701@gmail.com>
Download mbox | patch
Permalink /patch/63595/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jiri Slaby - Sept. 3, 2010, 8:35 a.m.
On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> On 06/02/2010 08:44 PM, Don Zickus wrote:
>> --- a/kernel/watchdog.c
>> +++ b/kernel/watchdog.c
>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
>>  		break;
>>  	case CPU_ONLINE:
>>  	case CPU_ONLINE_FROZEN:
>> -		if (watchdog_enable(hotcpu))
>> -			return NOTIFY_BAD;
>> +		watchdog_enable(hotcpu)
> 
> This fixes the problem indeed.

Hi, was this fixed somehow? I still use this hunk and don't know if it
is needed:
        case CPU_UP_CANCELED:

thanks,
Don Zickus - Sept. 3, 2010, 1:56 p.m.
On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> > On 06/02/2010 08:44 PM, Don Zickus wrote:
> >> --- a/kernel/watchdog.c
> >> +++ b/kernel/watchdog.c
> >> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
> >>  		break;
> >>  	case CPU_ONLINE:
> >>  	case CPU_ONLINE_FROZEN:
> >> -		if (watchdog_enable(hotcpu))
> >> -			return NOTIFY_BAD;
> >> +		watchdog_enable(hotcpu)
> > 
> > This fixes the problem indeed.
> 
> Hi, was this fixed somehow? I still use this hunk and don't know if it
> is needed:

I have to go re-review the problem again.  I might have forgot to bring it
in.  Thanks for reminding me!

Cheers,
Don

> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -524,7 +524,7 @@ cpu_callback(struct notifier_block *nfb, unsigned
> long action, void *hcpu)
>                 break;
>         case CPU_ONLINE:
>         case CPU_ONLINE_FROZEN:
> -               err = watchdog_enable(hotcpu);
> +               watchdog_enable(hotcpu);
>                 break;
>  #ifdef CONFIG_HOTPLUG_CPU
>         case CPU_UP_CANCELED:
> 
> thanks,
> -- 
> js
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Slaby - Sept. 24, 2010, 3:10 p.m.
On 09/03/2010 04:56 PM, Don Zickus wrote:
> On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
>> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
>>> On 06/02/2010 08:44 PM, Don Zickus wrote:
>>>> --- a/kernel/watchdog.c
>>>> +++ b/kernel/watchdog.c
>>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
>>>>  		break;
>>>>  	case CPU_ONLINE:
>>>>  	case CPU_ONLINE_FROZEN:
>>>> -		if (watchdog_enable(hotcpu))
>>>> -			return NOTIFY_BAD;
>>>> +		watchdog_enable(hotcpu)
>>>
>>> This fixes the problem indeed.
>>
>> Hi, was this fixed somehow? I still use this hunk and don't know if it
>> is needed:
> 
> I have to go re-review the problem again.  I might have forgot to bring it
> in.  Thanks for reminding me!

Reminder #2 :). Any updates?

thanks,
Don Zickus - Sept. 24, 2010, 6:24 p.m.
On Fri, Sep 24, 2010 at 06:10:02PM +0300, Jiri Slaby wrote:
> On 09/03/2010 04:56 PM, Don Zickus wrote:
> > On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
> >> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> >>> On 06/02/2010 08:44 PM, Don Zickus wrote:
> >>>> --- a/kernel/watchdog.c
> >>>> +++ b/kernel/watchdog.c
> >>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
> >>>>  		break;
> >>>>  	case CPU_ONLINE:
> >>>>  	case CPU_ONLINE_FROZEN:
> >>>> -		if (watchdog_enable(hotcpu))
> >>>> -			return NOTIFY_BAD;
> >>>> +		watchdog_enable(hotcpu)
> >>>
> >>> This fixes the problem indeed.
> >>
> >> Hi, was this fixed somehow? I still use this hunk and don't know if it
> >> is needed:
> > 
> > I have to go re-review the problem again.  I might have forgot to bring it
> > in.  Thanks for reminding me!
> 
> Reminder #2 :). Any updates?

No. I suck.  I was sidetracked on other stuff.  Let me put that together
today.

Thanks again for reminding me.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Don Zickus - Sept. 24, 2010, 7:19 p.m.
On Fri, Sep 24, 2010 at 06:10:02PM +0300, Jiri Slaby wrote:
> On 09/03/2010 04:56 PM, Don Zickus wrote:
> > On Fri, Sep 03, 2010 at 10:35:04AM +0200, Jiri Slaby wrote:
> >> On 06/06/2010 08:22 AM, Jiri Slaby wrote:
> >>> On 06/02/2010 08:44 PM, Don Zickus wrote:
> >>>> --- a/kernel/watchdog.c
> >>>> +++ b/kernel/watchdog.c
> >>>> @@ -550,8 +550,7 @@ cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
> >>>>  		break;
> >>>>  	case CPU_ONLINE:
> >>>>  	case CPU_ONLINE_FROZEN:
> >>>> -		if (watchdog_enable(hotcpu))
> >>>> -			return NOTIFY_BAD;
> >>>> +		watchdog_enable(hotcpu)
> >>>
> >>> This fixes the problem indeed.
> >>
> >> Hi, was this fixed somehow? I still use this hunk and don't know if it
> >> is needed:
> > 
> > I have to go re-review the problem again.  I might have forgot to bring it
> > in.  Thanks for reminding me!
> 
> Reminder #2 :). Any updates?

Actually there seems to have been some clean up in the cpu hotplug error
handling code.  Could you remove that snippet of code and see if the
problem still happens?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Slaby - Sept. 25, 2010, 7:30 p.m.
On 09/24/2010 10:19 PM, Don Zickus wrote:
> Actually there seems to have been some clean up in the cpu hotplug error
> handling code.  Could you remove that snippet of code and see if the
> problem still happens?

The thing is I don't remember what problems exactly I had. From the
description I wrote, I cannot reproduce it anymore :).

thanks for looking into that,
Don Zickus - Sept. 27, 2010, 2:21 p.m.
On Sat, Sep 25, 2010 at 10:30:35PM +0300, Jiri Slaby wrote:
> On 09/24/2010 10:19 PM, Don Zickus wrote:
> > Actually there seems to have been some clean up in the cpu hotplug error
> > handling code.  Could you remove that snippet of code and see if the
> > problem still happens?
> 
> The thing is I don't remember what problems exactly I had. From the
> description I wrote, I cannot reproduce it anymore :).
> 
> thanks for looking into that,

ok. :-)  Let me know if it pops up again.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -524,7 +524,7 @@  cpu_callback(struct notifier_block *nfb, unsigned
long action, void *hcpu)
                break;
        case CPU_ONLINE:
        case CPU_ONLINE_FROZEN:
-               err = watchdog_enable(hotcpu);
+               watchdog_enable(hotcpu);
                break;
 #ifdef CONFIG_HOTPLUG_CPU