| Message ID | 20160615115603.4897-13-grygorii.strashko@ti.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Jun 15, 2016 at 02:56:00PM +0300, Grygorii Strashko wrote: > Document missed "ti,am4372-mdio" compat string used for TI am437x SoC > (am4372.dtsi). > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > Documentation/devicetree/bindings/net/davinci-mdio.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/davinci-mdio.txt b/Documentation/devicetree/bindings/net/davinci-mdio.txt > index 0369e25..f2bba50 100644 > --- a/Documentation/devicetree/bindings/net/davinci-mdio.txt > +++ b/Documentation/devicetree/bindings/net/davinci-mdio.txt > @@ -2,7 +2,8 @@ TI SoC Davinci/Keystone2 MDIO Controller Device Tree Bindings > --------------------------------------------------- > > Required properties: > -- compatible : Should be "ti,davinci_mdio" or "ti,keystone_mdio" > +- compatible : Should be "ti,davinci_mdio", "ti,keystone_mdio", > + "ti,am4372-mdio" This is still an OR relationship? It's preferred to list one per line. > - reg : physical base address and size of the davinci mdio > registers map > - bus_freq : Mdio Bus frequency > -- > 2.8.4 >
On 06/19/2016 05:35 PM, Rob Herring wrote: > On Wed, Jun 15, 2016 at 02:56:00PM +0300, Grygorii Strashko wrote: >> Document missed "ti,am4372-mdio" compat string used for TI am437x SoC >> (am4372.dtsi). >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> Documentation/devicetree/bindings/net/davinci-mdio.txt | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/davinci-mdio.txt b/Documentation/devicetree/bindings/net/davinci-mdio.txt >> index 0369e25..f2bba50 100644 >> --- a/Documentation/devicetree/bindings/net/davinci-mdio.txt >> +++ b/Documentation/devicetree/bindings/net/davinci-mdio.txt >> @@ -2,7 +2,8 @@ TI SoC Davinci/Keystone2 MDIO Controller Device Tree Bindings >> --------------------------------------------------- >> >> Required properties: >> -- compatible : Should be "ti,davinci_mdio" or "ti,keystone_mdio" >> +- compatible : Should be "ti,davinci_mdio", "ti,keystone_mdio", >> + "ti,am4372-mdio" > > This is still an OR relationship? I think it's AND relation. It should be smth. like this: [SoC,][IP family,] "ti,davinci_mdio" where "ti,davinci_mdio" is mandatory always [IP family] - mandatory for IP/SOC family and can be "ti,keystone_mdio" or "ti,cpsw-mdio" (last one is added by subsequent patch) [SoC] - mandatory for SoC. now can be "ti,am4372-mdio" I can update it as below: - compatible : Should be "ti,davinci_mdio" and "ti,keystone_mdio" for Keystone 2 SoCs and "ti,am4372-mdio" for am472x SoC and in subsequent patch and "ti,cpsw-mdio" for am335x, am472x, am57xx/dra7, dm814x SoCs and "ti,am4372-mdio" for am472x SoC > > It's preferred to list one per line. ok
diff --git a/Documentation/devicetree/bindings/net/davinci-mdio.txt b/Documentation/devicetree/bindings/net/davinci-mdio.txt index 0369e25..f2bba50 100644 --- a/Documentation/devicetree/bindings/net/davinci-mdio.txt +++ b/Documentation/devicetree/bindings/net/davinci-mdio.txt @@ -2,7 +2,8 @@ TI SoC Davinci/Keystone2 MDIO Controller Device Tree Bindings --------------------------------------------------- Required properties: -- compatible : Should be "ti,davinci_mdio" or "ti,keystone_mdio" +- compatible : Should be "ti,davinci_mdio", "ti,keystone_mdio", + "ti,am4372-mdio" - reg : physical base address and size of the davinci mdio registers map - bus_freq : Mdio Bus frequency
Document missed "ti,am4372-mdio" compat string used for TI am437x SoC (am4372.dtsi). Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- Documentation/devicetree/bindings/net/davinci-mdio.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)