Patchwork Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

login
register
mail settings
Submitter Jonathan A. Kollasch
Date Sept. 2, 2010, 11:04 p.m.
Message ID <1283468684-13676-1-git-send-email-jakllsch@kollasch.net>
Download mbox | patch
Permalink /patch/63574/
State New
Headers show

Comments

Jonathan A. Kollasch - Sept. 2, 2010, 11:04 p.m.
From: Jonathan A. Kollasch <jakllsch@siwenna.kollasch.net>

Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
---
 hw/ide/core.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Jonathan A. Kollasch - Sept. 2, 2010, 11:10 p.m.
In case it isn't obvious, git hates me, a lot.  I may just give up on
this bug.

	Jonathan Kollasch
Alexander Graf - Sept. 2, 2010, 11:20 p.m.
On 03.09.2010, at 01:10, Jonathan A. Kollasch wrote:

> In case it isn't obvious, git hates me, a lot.  I may just give up on
> this bug.

Why? Things looked pretty good except for the subject line/content mess. When writing a patch, just make sure to have the subject be in the first line of the patch description, then an empty line, followed by the actual description.

---
This is the subject

This is some description.

Signed-off-by: asd <asdq@re.com>
---

git-format-mail then transforms this into a proper mail. It also helps to send it to yourself first, to check if everything is fine :).


Alex

Patch

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 3651d2b..2fa26f4 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -139,6 +139,7 @@  static void ide_identify(IDEState *s)
     put_le16(p + 61, s->nb_sectors >> 16);
     put_le16(p + 62, 0x07); /* single word dma0-2 supported */
     put_le16(p + 63, 0x07); /* mdma0-2 supported */
+    put_le16(p + 64, 0x03); /* pio3-4 supported */
     put_le16(p + 65, 120);
     put_le16(p + 66, 120);
     put_le16(p + 67, 120);
@@ -199,12 +200,12 @@  static void ide_atapi_identify(IDEState *s)
     put_le16(p + 53, 7); /* words 64-70, 54-58, 88 valid */
     put_le16(p + 62, 7);  /* single word dma0-2 supported */
     put_le16(p + 63, 7);  /* mdma0-2 supported */
-    put_le16(p + 64, 0x3f); /* PIO modes supported */
+    put_le16(p + 64, 3); /* pio3-4 supported */
 #else
     put_le16(p + 49, 1 << 9); /* LBA supported, no DMA */
     put_le16(p + 53, 3); /* words 64-70, 54-58 valid */
     put_le16(p + 63, 0x103); /* DMA modes XXX: may be incorrect */
-    put_le16(p + 64, 1); /* PIO modes */
+    put_le16(p + 64, 3); /* pio3-4 supported */
 #endif
     put_le16(p + 65, 0xb4); /* minimum DMA multiword tx cycle time */
     put_le16(p + 66, 0xb4); /* recommended DMA multiword tx cycle time */