| Message ID | 1465898827-2229-2-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jun 14, 2016 at 12:07 PM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Call of_property_read_u32_array() only once rather than iterating > of_property_read_u32_index(). > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Thanks patch applied! In this case I think the code is so old that the read_u32_array() function didn't exist when it was written. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 0e963ef..99fc40e 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -141,7 +141,7 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, .flags = &xlate_flags, }; u32 tmp; - int i, ret; + int ret; chip_np = np->parent; if (!chip_np) @@ -160,12 +160,10 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, gg_data.gpiospec.args_count = tmp; gg_data.gpiospec.np = chip_np; - for (i = 0; i < tmp; i++) { - ret = of_property_read_u32_index(np, "gpios", i, - &gg_data.gpiospec.args[i]); - if (ret) - return ERR_PTR(ret); - } + ret = of_property_read_u32_array(np, "gpios", gg_data.gpiospec.args, + tmp); + if (ret) + return ERR_PTR(ret); gpiochip_find(&gg_data, of_gpiochip_find_and_xlate); if (!gg_data.out_gpio) {
Call of_property_read_u32_array() only once rather than iterating of_property_read_u32_index(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/gpio/gpiolib-of.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)