Patchwork raw-posix: Don't use file name for host_cdrom detection on Linux

login
register
mail settings
Submitter Kevin Wolf
Date Sept. 2, 2010, 3:50 p.m.
Message ID <1283442609-11902-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/63501/
State New
Headers show

Comments

Kevin Wolf - Sept. 2, 2010, 3:50 p.m.
On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose
anything but false positives by removing the check for a /dev/cd* path.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/raw-posix.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Christoph Hellwig - Sept. 2, 2010, 4:50 p.m.
On Thu, Sep 02, 2010 at 05:50:09PM +0200, Kevin Wolf wrote:
> On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose
> anything but false positives by removing the check for a /dev/cd* path.

Agreed.


Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch

diff --git a/block/raw-posix.c b/block/raw-posix.c
index 240d84d..a3500f1 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1159,9 +1159,6 @@  static int cdrom_probe_device(const char *filename)
     int fd, ret;
     int prio = 0;
 
-    if (strstart(filename, "/dev/cd", NULL))
-        prio = 50;
-
     fd = open(filename, O_RDONLY | O_NONBLOCK);
     if (fd < 0) {
         goto out;