diff mbox

[U-Boot,22/27] net: phy: marvell: Add a missing errno.h header

Message ID 1465795839-16632-23-git-send-email-sjg@chromium.org
State Accepted
Commit fbfa1aba9181161fe5b38a180f20440a0511c051
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass June 13, 2016, 5:30 a.m. UTC 
This corrects a build error on zynqmp.

Signed-off-by: Simon Glass <sjg@chromium.odrg>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/net/phy/marvell.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Hershberger June 13, 2016, 6:21 p.m. UTC | #1 
Hi Simon,

On Mon, Jun 13, 2016 at 12:30 AM, Simon Glass <sjg@chromium.org> wrote:
> This corrects a build error on zynqmp.
>
> Signed-off-by: Simon Glass <sjg@chromium.odrg>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  drivers/net/phy/marvell.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index d2e68d4..8de0574 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -8,6 +8,7 @@
>   */
>  #include <config.h>
>  #include <common.h>
> +#include <errno.h>
>  #include <phy.h>

Maybe we can go ahead and apply this:

https://patchwork.ozlabs.org/patch/605766/

Otherwise,

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Michal Simek June 14, 2016, 5:55 a.m. UTC | #2 
On 13.6.2016 20:21, Joe Hershberger wrote:
> Hi Simon,
> 
> On Mon, Jun 13, 2016 at 12:30 AM, Simon Glass <sjg@chromium.org> wrote:
>> This corrects a build error on zynqmp.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.odrg>

Maybe fix this address too.

Thanks,
Michal
Simon Glass July 5, 2016, 10:24 p.m. UTC | #3 
Hi Joe,

On 13 June 2016 at 12:21, Joe Hershberger <joe.hershberger@gmail.com> wrote:
> Hi Simon,
>
> On Mon, Jun 13, 2016 at 12:30 AM, Simon Glass <sjg@chromium.org> wrote:
>> This corrects a build error on zynqmp.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.odrg>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>>  drivers/net/phy/marvell.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
>> index d2e68d4..8de0574 100644
>> --- a/drivers/net/phy/marvell.c
>> +++ b/drivers/net/phy/marvell.c
>> @@ -8,6 +8,7 @@
>>   */
>>  #include <config.h>
>>  #include <common.h>
>> +#include <errno.h>
>>  #include <phy.h>
>
> Maybe we can go ahead and apply this:
>
> https://patchwork.ozlabs.org/patch/605766/

That seems reasonable to me. I like splitting headers up, but this one
seems pretty fundamental.

>
> Otherwise,
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Regards,
Simon
diff mbox

Patch

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index d2e68d4..8de0574 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -8,6 +8,7 @@ 
  */
 #include <config.h>
 #include <common.h>
+#include <errno.h>
 #include <phy.h>
 
 #define PHY_AUTONEGOTIATE_TIMEOUT 5000