diff mbox

Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.

Message ID 1465769996-46245-1-git-send-email-sbruno@freebsd.org
State New
Headers show

Commit Message

Sean Bruno June 12, 2016, 10:19 p.m. UTC
The --quiet argument is not available on all operating systems.  Use -s
instead to match the rest of the Makefile uses.  This fixes a non-fatal
error see on FreeBSD.

Signed-off-by: Sean Bruno <sbruno@freebsd.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fam Zheng June 13, 2016, 12:32 a.m. UTC | #1
On Sun, 06/12 15:19, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems.  Use -s
> instead to match the rest of the Makefile uses.  This fixes a non-fatal
> error see on FreeBSD.

s/see/seen

(Perhaps can be fixed when applying.)

Reviewed-by: Fam Zheng <famz@redhat.com>

> 
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>  				printf '""\n'; \
>  			fi; \
>  		fi) > $@.tmp)
> -	$(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> +	$(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>  
>  config-host.h: config-host.h-timestamp
>  config-host.h-timestamp: config-host.mak
> -- 
> 2.8.1
> 
>
diff mbox

Patch

diff --git a/Makefile b/Makefile
index ed4032a..a7a356a 100644
--- a/Makefile
+++ b/Makefile
@@ -185,7 +185,7 @@  qemu-version.h: FORCE
 				printf '""\n'; \
 			fi; \
 		fi) > $@.tmp)
-	$(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
+	$(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
 
 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak