From patchwork Wed Sep 1 21:32:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 63420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3EA5EB7181 for ; Thu, 2 Sep 2010 07:32:49 +1000 (EST) Received: (qmail 28255 invoked by alias); 1 Sep 2010 21:32:46 -0000 Received: (qmail 28246 invoked by uid 22791); 1 Sep 2010 21:32:45 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (213.235.205.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Sep 2010 21:32:40 +0000 Received: from basil.firstfloor.org (p5B3C8169.dip0.t-ipconnect.de [91.60.129.105]) by one.firstfloor.org (Postfix) with ESMTP id 791DF1A9804F for ; Wed, 1 Sep 2010 23:32:36 +0200 (CEST) Received: by basil.firstfloor.org (Postfix, from userid 1000) id B28E3B2812; Wed, 1 Sep 2010 23:32:35 +0200 (CEST) Date: Wed, 1 Sep 2010 23:32:35 +0200 From: Andi Kleen To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix -fwhopr again Message-ID: <20100901213235.GA14449@basil.fritz.box> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, My earlier -fwhopr=jobserver patch unfortunately broke the "-fwhopr" without anything case, resulting in no LTO sections being generated in this case. This resulted in no visible failures because the backup code in the object files saved the day, but resulted in no real link time optimization. Following patch passed non LTO bootstrap C only on x86-64, currently running a full LTO bootstrap and a full test. Ok to commit if it passes? -Andi 2010-09-01 Andi Kleen * opts.c (common_handle_option): Fix OPT_fwhopr/fwhopr_ handling. diff --git a/gcc/opts.c b/gcc/opts.c index fbee8f6..7425fa4 100644 --- a/gcc/opts.c +++ b/gcc/opts.c @@ -2088,10 +2088,14 @@ common_handle_option (const struct cl_decoded_option *decoded, global_dc->pedantic_errors = 1; break; - case OPT_fwhopr: + case OPT_fwhopr_: flag_whopr = arg; break; + case OPT_fwhopr: + flag_whopr = ""; + break; + case OPT_w: global_dc->inhibit_warnings = true; break;