Patchwork Fix -fwhopr again

login
register
mail settings
Submitter Andi Kleen
Date Sept. 1, 2010, 9:32 p.m.
Message ID <20100901213235.GA14449@basil.fritz.box>
Download mbox | patch
Permalink /patch/63420/
State New
Headers show

Comments

Andi Kleen - Sept. 1, 2010, 9:32 p.m.
Hi,

My earlier -fwhopr=jobserver patch unfortunately broke the 
"-fwhopr" without anything case, resulting in no LTO
sections being generated in this case. This resulted
in no visible failures because the backup code 
in the object files saved the day, but resulted in no
real link time optimization.

Following patch passed non LTO bootstrap C only on x86-64,
currently running a full LTO bootstrap and a full test.

Ok to commit if it passes?

-Andi
 
2010-09-01  Andi Kleen  <ak@linux.intel.com>
    
    	* opts.c (common_handle_option): Fix OPT_fwhopr/fwhopr_ handling.
Diego Novillo - Sept. 1, 2010, 9:52 p.m.
On Wed, Sep 1, 2010 at 17:32, Andi Kleen <andi@firstfloor.org> wrote:

> Ok to commit if it passes?

Yes.


Diego.

Patch

diff --git a/gcc/opts.c b/gcc/opts.c
index fbee8f6..7425fa4 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -2088,10 +2088,14 @@  common_handle_option (const struct cl_decoded_option *decoded,
       global_dc->pedantic_errors = 1;
       break;
 
-    case OPT_fwhopr:
+    case OPT_fwhopr_:
       flag_whopr = arg;
       break;
 
+    case OPT_fwhopr:
+      flag_whopr = "";
+      break;
+
     case OPT_w:
       global_dc->inhibit_warnings = true;
       break;