diff mbox

[rs6000] Fix the vsx-elemrev-[24].c tests in a different way

Message ID A5D41506-8F81-434B-962A-21516EFB0EA9@linux.vnet.ibm.com
State New
Headers show

Commit Message

Bill Schmidt June 10, 2016, 4:16 p.m. UTC 
Hi,

After some discussion with the team, we decided the previous fix for these
tests was too draconian.  This patch no long requires the tests to be running
on Power9 hardware.  Thus the tests will still fail on machines that support
-mcpu=power9 at the command line, but have a downlevel binutils that won't
assemble the instructions.  (We'll upgrade the binutils on our P7 regression
tester.)  For now, we'll disable these tests from running on AIX until such time
as we have a better idea.

Verified on powerpc64le-unknown-linux-gnu with an updated binutils, and on
powerpc64-unknown-linux-gnu with an out-of-date binutils.  Is this ok for trunk?

Thanks,
Bill


2016-06-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* gcc.target/powerpc/vsx-elemrev-2.c: Change effective target
	requirements, and disable for AIX for now.
	* gcc.target/powerpc/vsx-elemrev-4.c: Likewise.

Comments

Segher Boessenkool June 14, 2016, 9:55 p.m. UTC | #1 
On Fri, Jun 10, 2016 at 11:16:03AM -0500, Bill Schmidt wrote:
> Verified on powerpc64le-unknown-linux-gnu with an updated binutils, and on
> powerpc64-unknown-linux-gnu with an out-of-date binutils.  Is this ok for trunk?

Okay.  "powerpc_p9vector_ok" is a confusing name, but it seems to be
just what we need here.


Segher


> 2016-06-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
> 
> 	* gcc.target/powerpc/vsx-elemrev-2.c: Change effective target
> 	requirements, and disable for AIX for now.
> 	* gcc.target/powerpc/vsx-elemrev-4.c: Likewise.
diff mbox

Patch

Index: gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c	(revision 237278)
+++ gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c	(working copy)
@@ -1,7 +1,8 @@ 
 /* { dg-do compile { target { powerpc64le*-*-* } } } */
 /* { dg-skip-if "do not override mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power9" } } */
 /* { dg-options "-mcpu=power9 -O0" } */
-/* { dg-require-effective-target p9vector_hw } */
+/* { dg-require-effective-target powerpc_p9vector_ok } */
+/* { dg-skip-if "" { powerpc*-*-aix* } { "*" } { "" } } */
 /* { dg-final { scan-assembler-times "lxvd2x" 6 } } */
 /* { dg-final { scan-assembler-times "lxvw4x" 6 } } */
 /* { dg-final { scan-assembler-times "lxvh8x" 4 } } */
Index: gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c	(revision 237278)
+++ gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c	(working copy)
@@ -1,7 +1,8 @@ 
 /* { dg-do compile { target { powerpc64-*-* } } } */
 /* { dg-skip-if "do not override mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power9" } } */
 /* { dg-options "-mcpu=power9 -O0" } */
-/* { dg-require-effective-target p9vector_hw } */
+/* { dg-require-effective-target powerpc_p9vector_ok } */
+/* { dg-skip-if "" { powerpc*-*-aix* } { "*" } { "" } } */
 /* { dg-final { scan-assembler-times "lxvx" 40 } } */
 /* { dg-final { scan-assembler-times "stxvx" 40 } } */