diff mbox

build: cleanup remaining references to BR2_STRIP_sstrip

Message ID 1465558082-3941-1-git-send-email-julien.floret@6wind.com
State Accepted
Headers show

Commit Message

Julien Floret June 10, 2016, 11:28 a.m. UTC
sstrip option has been removed in commit
106f5b8c5093 ("build: remove deprecated sstrip option").

Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 package/Makefile.in                  | 8 --------
 support/dependencies/dependencies.mk | 4 ----
 2 files changed, 12 deletions(-)

Comments

Thomas Petazzoni June 10, 2016, 6:16 p.m. UTC | #1
Hello,

On Fri, 10 Jun 2016 13:28:02 +0200, Julien Floret wrote:
> sstrip option has been removed in commit
> 106f5b8c5093 ("build: remove deprecated sstrip option").
> 
> Signed-off-by: Julien Floret <julien.floret@6wind.com>
> ---
>  package/Makefile.in                  | 8 --------
>  support/dependencies/dependencies.mk | 4 ----
>  2 files changed, 12 deletions(-)

Applied to master, thanks. I think package/sstrip/sstrip.mk could also
be simplified to get rid of the host variant, since it's not used
anywhere anymore.

It would be me, I would also remove the target variant, or at least
mark it as deprecated.

Thomas
diff mbox

Patch

diff --git a/package/Makefile.in b/package/Makefile.in
index 2d454a63820b..f6d1e6787cb9 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -201,14 +201,6 @@  TARGET_STRIP = $(TARGET_CROSS)strip
 STRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment --remove-section=.note
 KSTRIPCMD = $(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
 endif
-ifeq ($(BR2_STRIP_sstrip),y)
-STRIP_STRIP_DEBUG :=
-STRIP_STRIP_UNNEEDED :=
-STRIP_STRIP_ALL :=
-TARGET_STRIP = $(HOST_DIR)/usr/bin/$(GNU_TARGET_NAME)-sstrip
-STRIPCMD = $(TARGET_STRIP)
-KSTRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment --remove-section=.note --strip-unneeded
-endif
 ifeq ($(BR2_STRIP_none),y)
 TARGET_STRIP = true
 STRIPCMD = $(TARGET_STRIP)
diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk
index 82327216cd61..4334dac4e811 100644
--- a/support/dependencies/dependencies.mk
+++ b/support/dependencies/dependencies.mk
@@ -16,10 +16,6 @@  $(shell support/dependencies/check-host-$(1).sh $(2))
 endef
 -include $(sort $(wildcard support/dependencies/check-host-*.mk))
 
-ifeq ($(BR2_STRIP_sstrip),y)
-DEPENDENCIES_HOST_PREREQ += host-sstrip
-endif
-
 ifeq ($(BR2_CCACHE),y)
 DEPENDENCIES_HOST_PREREQ += host-ccache
 endif