| Message ID | 1465551464-8946-1-git-send-email-olivier.hardouin@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Oliver, 2016-06-10 11:37 GMT+02:00 <olivier.hardouin@gmail.com>: > Signed-off-by: Olivier Hardouin <olivier.hardouin@gmail.com> > --- Your patch doesn't have a commit message, which explains why these options are required by default. I've used mountd recently with ext4 and was able to read/write the mounted filesystem out of the box. Mathias > package/system/mountd/files/mountd.config | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/package/system/mountd/files/mountd.config b/package/system/mountd/files/mountd.config > index 5610129..c105606 100644 > --- a/package/system/mountd/files/mountd.config > +++ b/package/system/mountd/files/mountd.config > @@ -1,3 +1,31 @@ > config mountd mountd > option timeout 60 > option path /tmp/mounts/ > + > +config filesystem ext2 > + option options 'rw,defaults' > + option fstype 'ext2' > + > +config filesystem ext3 > + option options 'rw,defaults' > + option fstype 'ext3' > + > +config filesystem ext4 > + option options 'rw,defaults' > + option fstype 'ext4' > + > +config filesystem fat > + option options 'rw,uid=1000,gid=1000' > + option fstype 'vfat' > + > +config filesystem exfat > + option options 'rw,uid=1000,gid=1000' > + option fstype 'exfat' > + > +config filesystem hfsplus > + option options 'rw,defaults,uid=1000,gid=1000' > + option fstype 'hfsplus' > + > +config filesystem ntfs > + option options 'force' > + option fstype 'ntfs' > -- > 1.9.1 > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
On 10/06/2016 12:00, Mathias Kresin wrote: > Hi Oliver, > > 2016-06-10 11:37 GMT+02:00 <olivier.hardouin@gmail.com>: >> Signed-off-by: Olivier Hardouin <olivier.hardouin@gmail.com> >> --- > > Your patch doesn't have a commit message, which explains why these > options are required by default. > > I've used mountd recently with ext4 and was able to read/write the > mounted filesystem out of the box. > > Mathias looks like these are the defaults removed from the c code int he patch he sent 5 minutes before this patch John > >> package/system/mountd/files/mountd.config | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/package/system/mountd/files/mountd.config b/package/system/mountd/files/mountd.config >> index 5610129..c105606 100644 >> --- a/package/system/mountd/files/mountd.config >> +++ b/package/system/mountd/files/mountd.config >> @@ -1,3 +1,31 @@ >> config mountd mountd >> option timeout 60 >> option path /tmp/mounts/ >> + >> +config filesystem ext2 >> + option options 'rw,defaults' >> + option fstype 'ext2' >> + >> +config filesystem ext3 >> + option options 'rw,defaults' >> + option fstype 'ext3' >> + >> +config filesystem ext4 >> + option options 'rw,defaults' >> + option fstype 'ext4' >> + >> +config filesystem fat >> + option options 'rw,uid=1000,gid=1000' >> + option fstype 'vfat' >> + >> +config filesystem exfat >> + option options 'rw,uid=1000,gid=1000' >> + option fstype 'exfat' >> + >> +config filesystem hfsplus >> + option options 'rw,defaults,uid=1000,gid=1000' >> + option fstype 'hfsplus' >> + >> +config filesystem ntfs >> + option options 'force' >> + option fstype 'ntfs' >> -- >> 1.9.1 >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
Yes, you're right both patch are related. I'm trying to get more flexibility in mountd by passing the mount command options through UCI. On Fri, Jun 10, 2016 at 12:02 PM, John Crispin <john@phrozen.org> wrote: > > > On 10/06/2016 12:00, Mathias Kresin wrote: > > Hi Oliver, > > > > 2016-06-10 11:37 GMT+02:00 <olivier.hardouin@gmail.com>: > >> Signed-off-by: Olivier Hardouin <olivier.hardouin@gmail.com> > >> --- > > > > Your patch doesn't have a commit message, which explains why these > > options are required by default. > > > > I've used mountd recently with ext4 and was able to read/write the > > mounted filesystem out of the box. > > > > Mathias > > looks like these are the defaults removed from the c code int he patch > he sent 5 minutes before this patch > > John > > > > >> package/system/mountd/files/mountd.config | 28 > ++++++++++++++++++++++++++++ > >> 1 file changed, 28 insertions(+) > >> > >> diff --git a/package/system/mountd/files/mountd.config > b/package/system/mountd/files/mountd.config > >> index 5610129..c105606 100644 > >> --- a/package/system/mountd/files/mountd.config > >> +++ b/package/system/mountd/files/mountd.config > >> @@ -1,3 +1,31 @@ > >> config mountd mountd > >> option timeout 60 > >> option path /tmp/mounts/ > >> + > >> +config filesystem ext2 > >> + option options 'rw,defaults' > >> + option fstype 'ext2' > >> + > >> +config filesystem ext3 > >> + option options 'rw,defaults' > >> + option fstype 'ext3' > >> + > >> +config filesystem ext4 > >> + option options 'rw,defaults' > >> + option fstype 'ext4' > >> + > >> +config filesystem fat > >> + option options 'rw,uid=1000,gid=1000' > >> + option fstype 'vfat' > >> + > >> +config filesystem exfat > >> + option options 'rw,uid=1000,gid=1000' > >> + option fstype 'exfat' > >> + > >> +config filesystem hfsplus > >> + option options 'rw,defaults,uid=1000,gid=1000' > >> + option fstype 'hfsplus' > >> + > >> +config filesystem ntfs > >> + option options 'force' > >> + option fstype 'ntfs' > >> -- > >> 1.9.1 > >> _______________________________________________ > >> openwrt-devel mailing list > >> openwrt-devel@lists.openwrt.org > >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > > >
diff --git a/package/system/mountd/files/mountd.config b/package/system/mountd/files/mountd.config index 5610129..c105606 100644 --- a/package/system/mountd/files/mountd.config +++ b/package/system/mountd/files/mountd.config @@ -1,3 +1,31 @@ config mountd mountd option timeout 60 option path /tmp/mounts/ + +config filesystem ext2 + option options 'rw,defaults' + option fstype 'ext2' + +config filesystem ext3 + option options 'rw,defaults' + option fstype 'ext3' + +config filesystem ext4 + option options 'rw,defaults' + option fstype 'ext4' + +config filesystem fat + option options 'rw,uid=1000,gid=1000' + option fstype 'vfat' + +config filesystem exfat + option options 'rw,uid=1000,gid=1000' + option fstype 'exfat' + +config filesystem hfsplus + option options 'rw,defaults,uid=1000,gid=1000' + option fstype 'hfsplus' + +config filesystem ntfs + option options 'force' + option fstype 'ntfs'
Signed-off-by: Olivier Hardouin <olivier.hardouin@gmail.com> --- package/system/mountd/files/mountd.config | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)