| Message ID | 1465483515-10821-4-git-send-email-edumazet@google.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On 6/9/16 8:45 AM, Eric Dumazet wrote: > In case a qdisc is used on a vrf device, we need to use different > lockdep classes to avoid false positives. > > Use the new netdev_lockdep_set_classes() generic helper. > > Reported-by: David Ahern <dsa@cumulusnetworks.com> > Signed-off-by: Eric Dumazet <edumazet@google.com> > --- > drivers/net/vrf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index e3e693bf0dec..b82e3527924e 100644 > --- a/drivers/net/vrf.c > +++ b/drivers/net/vrf.c > @@ -661,7 +661,7 @@ static int vrf_dev_init(struct net_device *dev) > > /* similarly, oper state is irrelevant; set to up to avoid confusion */ > dev->operstate = IF_OPER_UP; > - > + netdev_lockdep_set_classes(dev); > return 0; > > out_rth: > Works for me. Thanks, Eric. Tested-by: David Ahern <dsa@cumulusnetworks.com>
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index e3e693bf0dec..b82e3527924e 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -661,7 +661,7 @@ static int vrf_dev_init(struct net_device *dev) /* similarly, oper state is irrelevant; set to up to avoid confusion */ dev->operstate = IF_OPER_UP; - + netdev_lockdep_set_classes(dev); return 0; out_rth:
In case a qdisc is used on a vrf device, we need to use different lockdep classes to avoid false positives. Use the new netdev_lockdep_set_classes() generic helper. Reported-by: David Ahern <dsa@cumulusnetworks.com> Signed-off-by: Eric Dumazet <edumazet@google.com> --- drivers/net/vrf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)