| Message ID | 1465470466-11379-1-git-send-email-ben.dooks@codethink.co.uk |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 06/09/2016 01:07 PM, Ben Dooks wrote: > The symbol ic_addrservaddr is not static, but has no declaration > to match. Since the similar variables are all exported, add this > one to the header file as well. > > This fixes the following warning: > > net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Well, how about making it actually static if it's only used from ipconfig.c ?
On 09/06/16 12:35, Daniel Borkmann wrote: > On 06/09/2016 01:07 PM, Ben Dooks wrote: >> The symbol ic_addrservaddr is not static, but has no declaration >> to match. Since the similar variables are all exported, add this >> one to the header file as well. >> >> This fixes the following warning: >> >> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not >> declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > > Well, how about making it actually static if it's only used > from ipconfig.c ? The only reason is that I thought someone might want to use it in the future. I have no particular insight though.
On 06/09/2016 02:11 PM, Ben Dooks wrote: > On 09/06/16 12:35, Daniel Borkmann wrote: >> On 06/09/2016 01:07 PM, Ben Dooks wrote: >>> The symbol ic_addrservaddr is not static, but has no declaration >>> to match. Since the similar variables are all exported, add this >>> one to the header file as well. >>> >>> This fixes the following warning: >>> >>> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not >>> declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> >> Well, how about making it actually static if it's only used >> from ipconfig.c ? > > The only reason is that I thought someone might want to > use it in the future. I have no particular insight though. Usual policy is that if such thing is required, then it can be exported along with the code that is making use of it from elsewhere. Thanks, Daniel
From: Daniel Borkmann <daniel@iogearbox.net> Date: Thu, 09 Jun 2016 14:15:43 +0200 > On 06/09/2016 02:11 PM, Ben Dooks wrote: >> On 09/06/16 12:35, Daniel Borkmann wrote: >>> On 06/09/2016 01:07 PM, Ben Dooks wrote: >>>> The symbol ic_addrservaddr is not static, but has no declaration >>>> to match. Since the similar variables are all exported, add this >>>> one to the header file as well. >>>> >>>> This fixes the following warning: >>>> >>>> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not >>>> declared. Should it be static? >>>> >>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >>> >>> Well, how about making it actually static if it's only used >>> from ipconfig.c ? >> >> The only reason is that I thought someone might want to >> use it in the future. I have no particular insight though. > > Usual policy is that if such thing is required, then it can be > exported along with the code that is making use of it from elsewhere. Right.
diff --git a/include/net/ipconfig.h b/include/net/ipconfig.h index c74cc1b..e5f4d6e 100644 --- a/include/net/ipconfig.h +++ b/include/net/ipconfig.h @@ -13,6 +13,7 @@ extern __be32 ic_myaddr; /* My IP address */ extern __be32 ic_gateway; /* Gateway IP address */ extern __be32 ic_servaddr; /* Boot server IP address */ +extern __be32 ic_addrservaddr; /* IP Address of the IP addresses'server */ extern __be32 root_server_addr; /* Address of NFS server */ extern u8 root_server_path[]; /* Path to mount as root */
The symbol ic_addrservaddr is not static, but has no declaration to match. Since the similar variables are all exported, add this one to the header file as well. This fixes the following warning: net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: "David S. Miller" <davem@davemloft.net> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> Cc: James Morris <jmorris@namei.org> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> Cc: Patrick McHardy <kaber@trash.net> Cc: netdev@vger.kernel.org --- include/net/ipconfig.h | 1 + 1 file changed, 1 insertion(+)