diff mbox

[4/6] gcc: remove occurrence of eglibc

Message ID 1465422059-22254-4-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit ce34ce8ec5cf24e43eced9c766e02369d5ea0484
Headers show

Commit Message

Thomas Petazzoni June 8, 2016, 9:40 p.m. UTC
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/gcc/gcc-final/gcc-final.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Romain Naour June 13, 2016, 8 p.m. UTC | #1
Hi Thomas,

Le 08/06/2016 à 23:40, Thomas Petazzoni a écrit :
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> ---
>  package/gcc/gcc-final/gcc-final.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index 721f4c8..78ceeba 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -115,7 +115,7 @@ HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_INSTALL_WRAPPER_AND_SIMPLE_SYMLINK
>  
>  # In gcc 4.7.x, the ARM EABIhf library loader path for glibc was not
>  # correct, so we create a symbolic link to make things work
> -# properly. eglibc installs the library loader as ld-linux-armhf.so.3,
> +# properly. glibc installs the library loader as ld-linux-armhf.so.3,
>  # but gcc creates binaries that reference ld-linux.so.3.
>  ifeq ($(BR2_arm)$(BR2_ARM_EABIHF)$(BR2_GCC_VERSION_4_7_X)$(BR2_TOOLCHAIN_USES_GLIBC),yyyy)
>  define HOST_GCC_FINAL_LD_LINUX_LINK
>
Yann E. MORIN June 13, 2016, 8:41 p.m. UTC | #2
Thomas, All,

On 2016-06-08 23:40 +0200, Thomas Petazzoni spake thusly:
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/gcc/gcc-final/gcc-final.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
> index 721f4c8..78ceeba 100644
> --- a/package/gcc/gcc-final/gcc-final.mk
> +++ b/package/gcc/gcc-final/gcc-final.mk
> @@ -115,7 +115,7 @@ HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_INSTALL_WRAPPER_AND_SIMPLE_SYMLINK
>  
>  # In gcc 4.7.x, the ARM EABIhf library loader path for glibc was not
>  # correct, so we create a symbolic link to make things work
> -# properly. eglibc installs the library loader as ld-linux-armhf.so.3,
> +# properly. glibc installs the library loader as ld-linux-armhf.so.3,

Yeah I remember something weird about that... However, the comment was
specifically speaking about eglibc. Was/is it also valid for glibc?

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  # but gcc creates binaries that reference ld-linux.so.3.
>  ifeq ($(BR2_arm)$(BR2_ARM_EABIHF)$(BR2_GCC_VERSION_4_7_X)$(BR2_TOOLCHAIN_USES_GLIBC),yyyy)
>  define HOST_GCC_FINAL_LD_LINUX_LINK
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard June 28, 2016, 8:26 p.m. UTC | #3
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk
index 721f4c8..78ceeba 100644
--- a/package/gcc/gcc-final/gcc-final.mk
+++ b/package/gcc/gcc-final/gcc-final.mk
@@ -115,7 +115,7 @@  HOST_GCC_FINAL_POST_INSTALL_HOOKS += HOST_GCC_INSTALL_WRAPPER_AND_SIMPLE_SYMLINK
 
 # In gcc 4.7.x, the ARM EABIhf library loader path for glibc was not
 # correct, so we create a symbolic link to make things work
-# properly. eglibc installs the library loader as ld-linux-armhf.so.3,
+# properly. glibc installs the library loader as ld-linux-armhf.so.3,
 # but gcc creates binaries that reference ld-linux.so.3.
 ifeq ($(BR2_arm)$(BR2_ARM_EABIHF)$(BR2_GCC_VERSION_4_7_X)$(BR2_TOOLCHAIN_USES_GLIBC),yyyy)
 define HOST_GCC_FINAL_LD_LINUX_LINK