| Message ID | 1465404897-16654-1-git-send-email-ben.dooks@codethink.co.uk |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: > The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing > from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> > so add that include to avoid the following warning: > > arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > arch/arm/mach-tegra/cpuidle.c | 1 + > 1 file changed, 1 insertion(+) I've been carrying a set of patches to fix these, and a couple of other sparse warnings, in my tree locally, but never sent them out because they were so trivial. I probably should've to avoid the duplication of effort. Sorry about that. Thierry
On 10/06/16 15:22, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: >> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing >> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> >> so add that include to avoid the following warning: >> >> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: Stephen Warren <swarren@wwwdotorg.org> >> Cc: Alexandre Courbot <gnurou@gmail.com> >> Cc: Thierry Reding <thierry.reding@gmail.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-tegra@vger.kernel.org >> --- >> arch/arm/mach-tegra/cpuidle.c | 1 + >> 1 file changed, 1 insertion(+) > > I've been carrying a set of patches to fix these, and a couple of other > sparse warnings, in my tree locally, but never sent them out because > they were so trivial. I probably should've to avoid the duplication of > effort. Sorry about that. I think you did send them out ;-) http://patchwork.ozlabs.org/patch/616249/ http://patchwork.ozlabs.org/patch/616250/ http://patchwork.ozlabs.org/patch/616251/ http://patchwork.ozlabs.org/patch/616252/ Jon
On Fri, Jun 10, 2016 at 03:33:25PM +0100, Jon Hunter wrote: > > On 10/06/16 15:22, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: > >> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing > >> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> > >> so add that include to avoid the following warning: > >> > >> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? > >> > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > >> --- > >> Cc: Stephen Warren <swarren@wwwdotorg.org> > >> Cc: Alexandre Courbot <gnurou@gmail.com> > >> Cc: Thierry Reding <thierry.reding@gmail.com> > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-tegra@vger.kernel.org > >> --- > >> arch/arm/mach-tegra/cpuidle.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > I've been carrying a set of patches to fix these, and a couple of other > > sparse warnings, in my tree locally, but never sent them out because > > they were so trivial. I probably should've to avoid the duplication of > > effort. Sorry about that. > > I think you did send them out ;-) > > http://patchwork.ozlabs.org/patch/616249/ > http://patchwork.ozlabs.org/patch/616250/ > http://patchwork.ozlabs.org/patch/616251/ > http://patchwork.ozlabs.org/patch/616252/ Hah! Excellent. No more guilty conscience for me. =) I've pulled those patches into the Tegra tree now. Thanks, Thierry
On 10/06/16 15:33, Jon Hunter wrote: > > On 10/06/16 15:22, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: >>> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing >>> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> >>> so add that include to avoid the following warning: >>> >>> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >>> --- >>> Cc: Stephen Warren <swarren@wwwdotorg.org> >>> Cc: Alexandre Courbot <gnurou@gmail.com> >>> Cc: Thierry Reding <thierry.reding@gmail.com> >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-tegra@vger.kernel.org >>> --- >>> arch/arm/mach-tegra/cpuidle.c | 1 + >>> 1 file changed, 1 insertion(+) >> >> I've been carrying a set of patches to fix these, and a couple of other >> sparse warnings, in my tree locally, but never sent them out because >> they were so trivial. I probably should've to avoid the duplication of >> effort. Sorry about that. Given it is likely that gcc warning flags will be updated it'd be good to get these issues sorted out.
On 10/06/16 15:55, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Jun 10, 2016 at 03:33:25PM +0100, Jon Hunter wrote: >> >> On 10/06/16 15:22, Thierry Reding wrote: >>>> Old Signed by an unknown key >>> >>> On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote: >>>> The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing >>>> from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> >>>> so add that include to avoid the following warning: >>>> >>>> arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? >>>> >>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >>>> --- >>>> Cc: Stephen Warren <swarren@wwwdotorg.org> >>>> Cc: Alexandre Courbot <gnurou@gmail.com> >>>> Cc: Thierry Reding <thierry.reding@gmail.com> >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-tegra@vger.kernel.org >>>> --- >>>> arch/arm/mach-tegra/cpuidle.c | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> I've been carrying a set of patches to fix these, and a couple of other >>> sparse warnings, in my tree locally, but never sent them out because >>> they were so trivial. I probably should've to avoid the duplication of >>> effort. Sorry about that. >> >> I think you did send them out ;-) >> >> http://patchwork.ozlabs.org/patch/616249/ >> http://patchwork.ozlabs.org/patch/616250/ >> http://patchwork.ozlabs.org/patch/616251/ >> http://patchwork.ozlabs.org/patch/616252/ > > Hah! Excellent. No more guilty conscience for me. =) > > I've pulled those patches into the Tegra tree now. Great! I have sent you a list of some others from patchwork that I think we should merge as well. Jon
diff --git a/arch/arm/mach-tegra/cpuidle.c b/arch/arm/mach-tegra/cpuidle.c index 3165631..b8e4568 100644 --- a/arch/arm/mach-tegra/cpuidle.c +++ b/arch/arm/mach-tegra/cpuidle.c @@ -25,6 +25,7 @@ #include <linux/module.h> #include <soc/tegra/fuse.h> +#include <soc/tegra/cpuidle.h> #include "cpuidle.h"
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h> so add that include to avoid the following warning: arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)