Patchwork RTC: do not mark PL031 IRQ as shared

login
register
mail settings
Submitter Linus Walleij
Date Aug. 31, 2010, 12:25 p.m.
Message ID <1283257550-5697-1-git-send-email-linus.walleij@stericsson.com>
Download mbox | patch
Permalink /patch/63239/
State New
Headers show

Comments

Linus Walleij - Aug. 31, 2010, 12:25 p.m.
It was a mistake to mark the PL031 IRQ as shared (for the U8500),
we misread the datasheet. Get rid of this.

Cc: Jonas Aberg <jonas.aberg@stericsson.com>
Cc: Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
 drivers/rtc/rtc-pl031.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Alessandro Zummo - Sept. 6, 2010, 7:11 p.m.
On Tue, 31 Aug 2010 14:25:50 +0200
Linus Walleij <linus.walleij@stericsson.com> wrote:

> It was a mistake to mark the PL031 IRQ as shared (for the U8500),
> we misread the datasheet. Get rid of this.
> 
> Cc: Jonas Aberg <jonas.aberg@stericsson.com>
> Cc: Mian Yousaf Kaukab <mian.yousaf.kaukab@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>

 Acked-by: Alessandro Zummo <a.zummo@towertech.it>

Patch

diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 6c418fe..b7a6690 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -403,7 +403,7 @@  static int pl031_probe(struct amba_device *adev, struct amba_id *id)
 	}
 
 	if (request_irq(adev->irq[0], pl031_interrupt,
-			IRQF_DISABLED | IRQF_SHARED, "rtc-pl031", ldata)) {
+			IRQF_DISABLED, "rtc-pl031", ldata)) {
 		ret = -EIO;
 		goto out_no_irq;
 	}