| Message ID | 1465387659-30011-3-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Commit | e264e3cc5be81548c6f102b6b597a474e5bd4f20 |
| Delegated to: | Bin Meng |
| Headers | show |
On 08.06.2016 14:07, Bin Meng wrote: > Without a 'reg' property, pinctrl driver probe routine fails in > its pre_probe() with a return value of -EINVAL. > > Add 'reg' property for all BayTrail boards. Note for BayleyBay, > the pinctrl node is newly added. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
On 8 June 2016 at 06:07, Bin Meng <bmeng.cn@gmail.com> wrote: > Without a 'reg' property, pinctrl driver probe routine fails in > its pre_probe() with a return value of -EINVAL. > > Add 'reg' property for all BayTrail boards. Note for BayleyBay, > the pinctrl node is newly added. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > arch/x86/dts/bayleybay.dts | 5 +++++ > arch/x86/dts/conga-qeval20-qa3-e3845.dts | 1 + > arch/x86/dts/minnowmax.dts | 1 + > 3 files changed, 7 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Fri, Jun 10, 2016 at 8:35 AM, Simon Glass <sjg@chromium.org> wrote: > On 8 June 2016 at 06:07, Bin Meng <bmeng.cn@gmail.com> wrote: >> Without a 'reg' property, pinctrl driver probe routine fails in >> its pre_probe() with a return value of -EINVAL. >> >> Add 'reg' property for all BayTrail boards. Note for BayleyBay, >> the pinctrl node is newly added. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> arch/x86/dts/bayleybay.dts | 5 +++++ >> arch/x86/dts/conga-qeval20-qa3-e3845.dts | 1 + >> arch/x86/dts/minnowmax.dts | 1 + >> 3 files changed, 7 insertions(+) > > Reviewed-by: Simon Glass <sjg@chromium.org> applied to u-boot-x86, thanks!
diff --git a/arch/x86/dts/bayleybay.dts b/arch/x86/dts/bayleybay.dts index 4a50d86..536049b 100644 --- a/arch/x86/dts/bayleybay.dts +++ b/arch/x86/dts/bayleybay.dts @@ -65,6 +65,11 @@ }; }; + pch_pinctrl { + compatible = "intel,x86-pinctrl"; + reg = <0 0>; + }; + pci { compatible = "pci-x86"; #address-cells = <3>; diff --git a/arch/x86/dts/conga-qeval20-qa3-e3845.dts b/arch/x86/dts/conga-qeval20-qa3-e3845.dts index 1a4ecaa..7e69ba4 100644 --- a/arch/x86/dts/conga-qeval20-qa3-e3845.dts +++ b/arch/x86/dts/conga-qeval20-qa3-e3845.dts @@ -30,6 +30,7 @@ pch_pinctrl { compatible = "intel,x86-pinctrl"; + reg = <0 0>; }; chosen { diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts index 936455b..fda170c 100644 --- a/arch/x86/dts/minnowmax.dts +++ b/arch/x86/dts/minnowmax.dts @@ -29,6 +29,7 @@ pch_pinctrl { compatible = "intel,x86-pinctrl"; + reg = <0 0>; /* GPIO E0 */ soc_gpio_s5_0@0 {
Without a 'reg' property, pinctrl driver probe routine fails in its pre_probe() with a return value of -EINVAL. Add 'reg' property for all BayTrail boards. Note for BayleyBay, the pinctrl node is newly added. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- arch/x86/dts/bayleybay.dts | 5 +++++ arch/x86/dts/conga-qeval20-qa3-e3845.dts | 1 + arch/x86/dts/minnowmax.dts | 1 + 3 files changed, 7 insertions(+)