From patchwork Tue Aug 31 09:22:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Kohl X-Patchwork-Id: 63216 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5D0D4B712B for ; Tue, 31 Aug 2010 19:32:28 +1000 (EST) Received: from localhost ([127.0.0.1]:59669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqNBm-0001ro-CN for incoming@patchwork.ozlabs.org; Tue, 31 Aug 2010 05:31:34 -0400 Received: from [140.186.70.92] (port=55776 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqN7l-0000AM-NJ for qemu-devel@nongnu.org; Tue, 31 Aug 2010 05:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqN3s-0002Ex-5u for qemu-devel@nongnu.org; Tue, 31 Aug 2010 05:23:24 -0400 Received: from demumfd002.nsn-inter.net ([93.183.12.31]:11383) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqN3r-0002Ee-Mk for qemu-devel@nongnu.org; Tue, 31 Aug 2010 05:23:24 -0400 Received: from demuprx017.emea.nsn-intra.net ([10.150.129.56]) by demumfd002.nsn-inter.net (8.12.11.20060308/8.12.11) with ESMTP id o7V9NMbN021639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Aug 2010 11:23:22 +0200 Received: from localhost6.localdomain6 ([10.148.23.89]) by demuprx017.emea.nsn-intra.net (8.12.11.20060308/8.12.11) with ESMTP id o7V9Mp4j025395; Tue, 31 Aug 2010 11:23:22 +0200 From: Bernhard Kohl To: qemu-devel@nongnu.org Date: Tue, 31 Aug 2010 11:22:33 +0200 Message-Id: <1283246554-10253-6-git-send-email-bernhard.kohl@nsn.com> X-Mailer: git-send-email 1.7.2.2 In-Reply-To: <1283246554-10253-1-git-send-email-bernhard.kohl@nsn.com> References: <1283246554-10253-1-git-send-email-bernhard.kohl@nsn.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: kwolf@redhat.com, Bernhard Kohl Subject: [Qemu-devel] [PATCH v2 5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "An initiator may request any one or all of the supported mode pages from a target. If an initiator issues a MODE SENSE command with a page code value not implemented by the target, the target shall return CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST and the additional sense code to INVALID FIELD IN CDB." Signed-off-by: Bernhard Kohl --- hw/scsi-disk.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index aef9199..0041038 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -690,6 +690,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf) p += mode_sense_page(req, 0x08, p, page_control); p += mode_sense_page(req, 0x2a, p, page_control); break; + default: + return -1; /* ILLEGAL_REQUEST */ } buflen = p - outbuf;