Patchwork [v2,5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command

mail settings
Submitter Bernhard Kohl
Date Aug. 31, 2010, 9:22 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/63216/
State New
Headers show


Bernhard Kohl - Aug. 31, 2010, 9:22 a.m.
"An initiator may request any one or all of the supported mode pages
from a target. If an initiator issues a MODE SENSE command with a
page code value not implemented by the target, the target shall return
CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST
and the additional sense code to INVALID FIELD IN CDB."

Signed-off-by: Bernhard Kohl <>
 hw/scsi-disk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index aef9199..0041038 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -690,6 +690,8 @@  static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf)
         p += mode_sense_page(req, 0x08, p, page_control);
         p += mode_sense_page(req, 0x2a, p, page_control);
+    default:
+        return -1; /* ILLEGAL_REQUEST */
     buflen = p - outbuf;