From patchwork Tue Aug 31 07:30:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jes Sorensen X-Patchwork-Id: 63208 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 19201B7110 for ; Tue, 31 Aug 2010 17:42:28 +1000 (EST) Received: from localhost ([127.0.0.1]:57739 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqLU9-0007Rt-9D for incoming@patchwork.ozlabs.org; Tue, 31 Aug 2010 03:42:25 -0400 Received: from [140.186.70.92] (port=47650 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqLJ0-0007ke-9k for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqLIz-0003nb-9q for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5042) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqLIz-0003nQ-3c for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:53 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7V7Uohv031653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Aug 2010 03:30:50 -0400 Received: from localhost6.localdomain6 ([10.3.121.6]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7V7UdDL025424; Tue, 31 Aug 2010 03:30:49 -0400 From: Jes.Sorensen@redhat.com To: qemu-devel@nongnu.org Date: Tue, 31 Aug 2010 09:30:38 +0200 Message-Id: <1283239838-20349-7-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1283239838-20349-1-git-send-email-Jes.Sorensen@redhat.com> References: <1283239838-20349-1-git-send-email-Jes.Sorensen@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: blauwirbel@gmail.com, Jes.Sorensen@redhat.com Subject: [Qemu-devel] [PATCH 6/6] load_multiboot(): get_image_size() returns int X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jes Sorensen Do not store return of get_image_size() in a uint32_t as it makes it impossible to detect error returns from get_image_size. Signed-off-by: Jes Sorensen --- hw/multiboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index dc980e6..f9097a2 100644 --- a/hw/multiboot.c +++ b/hw/multiboot.c @@ -252,7 +252,7 @@ int load_multiboot(void *fw_cfg, do { char *next_space; - uint32_t mb_mod_length; + int mb_mod_length; uint32_t offs = mbs.mb_buf_size; next_initrd = strchr(initrd_filename, ',');