| Message ID | d16b9cde449b0f6bad954c7ac1db2ac941231601.1465304877.git.jglauber@cavium.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jun 08, 2016 at 08:51:17AM +0200, Jan Glauber wrote: > During receive the controller requires the AAK flag for all > bytes but the final one. This was wrong in case of I2C_M_RECV_LEN, > where the decision if the final byte is to be transmitted > happened before adding the additional received length byte. > > Set the AAK flag if additional bytes are to be received. > > Signed-off-by: Jan Glauber <jglauber@cavium.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index aa5f01e..1922e4a 100644 --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/busses/i2c-octeon.c @@ -934,8 +934,15 @@ static int octeon_i2c_read(struct octeon_i2c *i2c, int target, return result; for (i = 0; i < length; i++) { - /* for the last byte TWSI_CTL_AAK must not be set */ - if (i + 1 == length) + /* + * For the last byte to receive TWSI_CTL_AAK must not be set. + * + * A special case is I2C_M_RECV_LEN where we don't know the + * additional length yet. If recv_len is set we assume we're + * not reading the final byte and therefore need to set + * TWSI_CTL_AAK. + */ + if ((i + 1 == length) && !(recv_len && i == 0)) final_read = true; /* clear iflg to allow next event */
During receive the controller requires the AAK flag for all bytes but the final one. This was wrong in case of I2C_M_RECV_LEN, where the decision if the final byte is to be transmitted happened before adding the additional received length byte. Set the AAK flag if additional bytes are to be received. Signed-off-by: Jan Glauber <jglauber@cavium.com> --- drivers/i2c/busses/i2c-octeon.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)