| Message ID | 20160607193345.GA10562@Karyakshetra |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi, On 6/7/2016 12:33 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > Since the driver is infiniband which can be used as block device and the > workqueue seems involved in regular operation of the device, so a > dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee > forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > --- Looks fine. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Date: Wed, 8 Jun 2016 01:03:45 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > Since the driver is infiniband which can be used as block device and the > workqueue seems involved in regular operation of the device, so a > dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee > forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Applied, thanks.
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index f7164ac..a0f21b6 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -618,7 +618,7 @@ struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_ibdev, int rds_ib_mr_init(void) { - rds_ib_mr_wq = create_workqueue("rds_mr_flushd"); + rds_ib_mr_wq = alloc_workqueue("rds_mr_flushd", WQ_MEM_RECLAIM, 0); if (!rds_ib_mr_wq) return -ENOMEM; return 0;
alloc_workqueue replaces deprecated create_workqueue(). Since the driver is infiniband which can be used as block device and the workqueue seems involved in regular operation of the device, so a dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee forward progress under memory pressure. Since there are only a fixed number of work items, explicit concurrency limit is unnecessary here. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- net/rds/ib_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4