| Message ID | 1465320357-3718-1-git-send-email-hutamanzi@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 2016-06-07 19:25, Bima Hutama wrote: > -Description: > Include support for GNU Readline and History Libraries in wpa_cli. By enabling > this, we will get history support for wpa_cli, so that wpa_cli-interactive-mode > interprets up and down key as historical commands rather than just not-interpretable > "^[[A" or "^[[B" strings. > > -Changelog: > Enabling CONFIG_READLINE=y. > > Signed-off-by: Bima Hutama <hutamanzi@gmail.com> > --- > package/network/services/hostapd/files/wpa_supplicant-full.config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/network/services/hostapd/files/wpa_supplicant-full.config b/package/network/services/hostapd/files/wpa_supplicant-full.config > index 441eab1..dd1ef8c 100644 > --- a/package/network/services/hostapd/files/wpa_supplicant-full.config > +++ b/package/network/services/hostapd/files/wpa_supplicant-full.config > @@ -222,7 +222,7 @@ CONFIG_CTRL_IFACE=y > # When building a wpa_cli binary for distribution, please note that these > # libraries are licensed under GPL and as such, BSD license may not apply for > # the resulting binary. > -#CONFIG_READLINE=y > +CONFIG_READLINE=y Does this link in libreadline statically? If not, a dependency is necessary. Also, since wpa_cli is shared between the full and mini variant, I'd prefer a separate option for this (disabled by default). - Felix
diff --git a/package/network/services/hostapd/files/wpa_supplicant-full.config b/package/network/services/hostapd/files/wpa_supplicant-full.config index 441eab1..dd1ef8c 100644 --- a/package/network/services/hostapd/files/wpa_supplicant-full.config +++ b/package/network/services/hostapd/files/wpa_supplicant-full.config @@ -222,7 +222,7 @@ CONFIG_CTRL_IFACE=y # When building a wpa_cli binary for distribution, please note that these # libraries are licensed under GPL and as such, BSD license may not apply for # the resulting binary. -#CONFIG_READLINE=y +CONFIG_READLINE=y # Remove debugging code that is printing out debug message to stdout. # This can be used to reduce the size of the wpa_supplicant considerably
-Description: Include support for GNU Readline and History Libraries in wpa_cli. By enabling this, we will get history support for wpa_cli, so that wpa_cli-interactive-mode interprets up and down key as historical commands rather than just not-interpretable "^[[A" or "^[[B" strings. -Changelog: Enabling CONFIG_READLINE=y. Signed-off-by: Bima Hutama <hutamanzi@gmail.com> --- package/network/services/hostapd/files/wpa_supplicant-full.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)