diff mbox

[5/6] tests: ap_csa channel switch inc timeout for remote tests

Message ID 1465306963-22464-5-git-send-email-jonathan@wizery.com
State Superseded
Headers show

Commit Message

Jonathan Afek June 7, 2016, 1:42 p.m. UTC
The ap_csa tests are testing the channel switch functionality.
After performing a channel switch the test used to sleep for 0.1
seconds. For real hw the operation takes a bit longer so the
timeout is increased to 1 second.

Signed-off-by: Jonathan Afek <jonathanx.afek@intel.com>
---
 tests/hwsim/test_ap_csa.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen June 27, 2016, 5:27 p.m. UTC | #1
On Tue, Jun 07, 2016 at 04:42:42PM +0300, Jonathan Afek wrote:
> The ap_csa tests are testing the channel switch functionality.
> After performing a channel switch the test used to sleep for 0.1
> seconds. For real hw the operation takes a bit longer so the
> timeout is increased to 1 second.

I'm adding a new wpa_supplicant control interface event to report
channel switches and changing ap_csa test cases to wait on this event
instead of the fixed duration here. That move to 1 second would have
almost doubled the test execution time and that new event message is of
use for more purposes as well.
diff mbox

Patch

diff --git a/tests/hwsim/test_ap_csa.py b/tests/hwsim/test_ap_csa.py
index 02943ae..7ff94a6 100644
--- a/tests/hwsim/test_ap_csa.py
+++ b/tests/hwsim/test_ap_csa.py
@@ -27,7 +27,7 @@  def switch_channel(ap, count, freq):
         raise Exception("CSA finished event timed out")
     if "freq=" + str(freq) not in ev:
         raise Exception("Unexpected channel in CSA finished event")
-    time.sleep(0.1)
+    time.sleep(1)
 
 # This function checks whether the provided dev, which may be either
 # WpaSupplicant or Hostapd supports CSA.