| Message ID | 1465306963-22464-2-git-send-email-jonathan@wizery.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Jun 07, 2016 at 04:42:39PM +0300, Jonathan Afek wrote: > Use increased timeouts for connect and disconnect since these > operations take a longer time on real harware than they do > on hwsim. I think these should also be made conditional on remote testing to avoid unnecessary delays for the mac80211_hwsim case. That said, I'm not really sure how even real hardware should take more than 10 seconds to connect or disconnect..
On Mon, Jun 27, 2016 at 6:07 PM, Jouni Malinen <j@w1.fi> wrote: > I think these should also be made conditional on remote testing to avoid > unnecessary delays for the mac80211_hwsim case. That said, I'm not > really sure how even real hardware should take more than 10 seconds to > connect or disconnect.. This was an issue when testing on real hardware because of long scans. Sending another version for the patch.
diff --git a/tests/hwsim/wpasupplicant.py b/tests/hwsim/wpasupplicant.py index 7d80d6b..46d38f2 100644 --- a/tests/hwsim/wpasupplicant.py +++ b/tests/hwsim/wpasupplicant.py @@ -390,7 +390,7 @@ class WpaSupplicant: raise Exception("MESH_GROUP_REMOVE failed") return None - def connect_network(self, id, timeout=10): + def connect_network(self, id, timeout=60): self.dump_monitor() self.select_network(id) self.wait_connected(timeout=timeout) @@ -1224,7 +1224,7 @@ class WpaSupplicant: raise Exception(error) return ev - def wait_disconnected(self, timeout=10, error="Disconnection timed out"): + def wait_disconnected(self, timeout=30, error="Disconnection timed out"): ev = self.wait_event(["CTRL-EVENT-DISCONNECTED"], timeout=timeout) if ev is None: raise Exception(error)
Use increased timeouts for connect and disconnect since these operations take a longer time on real harware than they do on hwsim. Signed-off-by: Jonathan Afek <jonathanx.afek@intel.com> --- tests/hwsim/wpasupplicant.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)