diff mbox

[2/3] Makefile: add dependency on scripts/make_device_config.sh

Message ID 1465300083-72463-3-git-send-email-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini June 7, 2016, 11:48 a.m. UTC
Make sure that config-devices.mak is rebuilt whenever
there is a change in the scripts that generates it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Maydell June 7, 2016, 11:59 a.m. UTC | #1
On 7 June 2016 at 12:48, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Make sure that config-devices.mak is rebuilt whenever
> there is a change in the scripts that generates it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 9e0e1f8..72e0d74 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -117,7 +117,7 @@ endif
>
>  -include $(SUBDIR_DEVICES_MAK_DEP)
>
> -%/config-devices.mak: default-configs/%.mak
> +%/config-devices.mak: default-configs/%.mak $(SRC_PATH)/scripts/make_device_config.sh
>         $(call quiet-command, \
>              $(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $< $*-config-devices.mak.d $@ > $@.tmp, "  GEN   $@.tmp")
>         $(call quiet-command, if test -f $@; then \
> --
> 1.8.3.1

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(In this case you have added it to the pattern rule...)

thanks
-- PMM
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 9e0e1f8..72e0d74 100644
--- a/Makefile
+++ b/Makefile
@@ -117,7 +117,7 @@  endif
 
 -include $(SUBDIR_DEVICES_MAK_DEP)
 
-%/config-devices.mak: default-configs/%.mak
+%/config-devices.mak: default-configs/%.mak $(SRC_PATH)/scripts/make_device_config.sh
 	$(call quiet-command, \
             $(SHELL) $(SRC_PATH)/scripts/make_device_config.sh $< $*-config-devices.mak.d $@ > $@.tmp, "  GEN   $@.tmp")
 	$(call quiet-command, if test -f $@; then \