[STABLE,0.13,4/6] qemu-img rebase: Open new backing file read-only

Message ID 1283187233-3925-5-git-send-email-kwolf@redhat.com
State New
Headers show

Commit Message

Kevin Wolf Aug. 30, 2010, 4:53 p.m.
We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit cdbae85169c384d1641aa1ae86cdeefe16285745)
 qemu-img.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/qemu-img.c b/qemu-img.c
index e300f91..d2a978b 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1286,7 +1286,7 @@  static int img_rebase(int argc, char **argv)
         bs_new_backing = bdrv_new("new_backing");
-        ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS | BDRV_O_RDWR,
+        ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS,
         if (ret) {
             error("Could not open new backing file '%s'", out_baseimg);