| Message ID | 1465206294-38490-1-git-send-email-sivadur@xilinx.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
Hi Tom, > -----Original Message----- > From: Siva Durga Prasad Paladugu > Sent: Tuesday, June 14, 2016 2:49 PM > To: u-boot@lists.denx.de; jagannadh.teki@gmail.com > Cc: Michal Simek <michals@xilinx.com>; 'Siva Durga Prasad Paladugu' > <siva.durga.paladugu@xilinx.com> > Subject: RE: [PATCH 1/9] spi: zynq_qspi: Add quad support for zynq qspi > > > -----Original Message----- > From: Siva Durga Prasad Paladugu [mailto:siva.durga.paladugu@xilinx.com] > Sent: Monday, June 06, 2016 3:15 PM > To: u-boot@lists.denx.de > Cc: Michal Simek <michals@xilinx.com>; jagannadh.teki@gmail.com; Siva Durga > Prasad Paladugu <sivadur@xilinx.com> > Subject: [PATCH 1/9] spi: zynq_qspi: Add quad support for zynq qspi > > Add quad commands supports for zynq qspi driver > > Hi Jagan, > > Any comments on this series. If not, Please take this series. > > Regards, > Siva Same is the case with this series too, If Jagan is busy, Is it possible to get it Acked/Reviewed by some other person and can go through your tree/Michal tree. Regards, Siva > > Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > --- > - Tested on zc702 board > --- > drivers/spi/zynq_qspi.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c index > b98663c..e636244 100644 > --- a/drivers/spi/zynq_qspi.c > +++ b/drivers/spi/zynq_qspi.c > @@ -11,7 +11,9 @@ > #include <dm.h> > #include <malloc.h> > #include <spi.h> > +#include <spi_flash.h> > #include <asm/io.h> > +#include "../mtd/spi/sf_internal.h" > > DECLARE_GLOBAL_DATA_PTR; > > @@ -156,6 +158,17 @@ static void zynq_qspi_init_hw(struct zynq_qspi_priv > *priv) > writel(ZYNQ_QSPI_ENR_SPI_EN_MASK, ®s->enr); } > > +static int zynq_qspi_child_pre_probe(struct udevice *bus) { > + struct spi_slave *slave = dev_get_parent_priv(bus); > + > + slave->mode_rx = QUAD_OUTPUT_FAST; > + slave->mode = SPI_TX_QUAD; > + slave->no_all_quad = 1; > + > + return 0; > +} > + > static int zynq_qspi_probe(struct udevice *bus) { > struct zynq_qspi_platdata *plat = dev_get_platdata(bus); @@ -627,4 > +640,5 @@ U_BOOT_DRIVER(zynq_qspi) = { > .platdata_auto_alloc_size = sizeof(struct zynq_qspi_platdata), > .priv_auto_alloc_size = sizeof(struct zynq_qspi_priv), > .probe = zynq_qspi_probe, > + .child_pre_probe = zynq_qspi_child_pre_probe, > }; > -- > 1.7.1 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
On 21 June 2016 at 17:24, Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com> wrote: > Hi Tom, > >> -----Original Message----- >> From: Siva Durga Prasad Paladugu >> Sent: Tuesday, June 14, 2016 2:49 PM >> To: u-boot@lists.denx.de; jagannadh.teki@gmail.com >> Cc: Michal Simek <michals@xilinx.com>; 'Siva Durga Prasad Paladugu' >> <siva.durga.paladugu@xilinx.com> >> Subject: RE: [PATCH 1/9] spi: zynq_qspi: Add quad support for zynq qspi >> >> >> -----Original Message----- >> From: Siva Durga Prasad Paladugu [mailto:siva.durga.paladugu@xilinx.com] >> Sent: Monday, June 06, 2016 3:15 PM >> To: u-boot@lists.denx.de >> Cc: Michal Simek <michals@xilinx.com>; jagannadh.teki@gmail.com; Siva Durga >> Prasad Paladugu <sivadur@xilinx.com> >> Subject: [PATCH 1/9] spi: zynq_qspi: Add quad support for zynq qspi >> >> Add quad commands supports for zynq qspi driver >> >> Hi Jagan, >> >> Any comments on this series. If not, Please take this series. Please wait I will back with my comments. > > Same is the case with this series too, If Jagan is busy, Is it possible to get it Acked/Reviewed by some other person > and can go through your tree/Michal tree. > > Regards, > Siva > >> >> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> >> --- >> - Tested on zc702 board >> --- >> drivers/spi/zynq_qspi.c | 14 ++++++++++++++ >> 1 files changed, 14 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c index >> b98663c..e636244 100644 >> --- a/drivers/spi/zynq_qspi.c >> +++ b/drivers/spi/zynq_qspi.c >> @@ -11,7 +11,9 @@ >> #include <dm.h> >> #include <malloc.h> >> #include <spi.h> >> +#include <spi_flash.h> >> #include <asm/io.h> >> +#include "../mtd/spi/sf_internal.h" >> >> DECLARE_GLOBAL_DATA_PTR; >> >> @@ -156,6 +158,17 @@ static void zynq_qspi_init_hw(struct zynq_qspi_priv >> *priv) >> writel(ZYNQ_QSPI_ENR_SPI_EN_MASK, ®s->enr); } >> >> +static int zynq_qspi_child_pre_probe(struct udevice *bus) { >> + struct spi_slave *slave = dev_get_parent_priv(bus); >> + >> + slave->mode_rx = QUAD_OUTPUT_FAST; >> + slave->mode = SPI_TX_QUAD; >> + slave->no_all_quad = 1; >> + >> + return 0; >> +} >> + >> static int zynq_qspi_probe(struct udevice *bus) { >> struct zynq_qspi_platdata *plat = dev_get_platdata(bus); @@ -627,4 >> +640,5 @@ U_BOOT_DRIVER(zynq_qspi) = { >> .platdata_auto_alloc_size = sizeof(struct zynq_qspi_platdata), >> .priv_auto_alloc_size = sizeof(struct zynq_qspi_priv), >> .probe = zynq_qspi_probe, >> + .child_pre_probe = zynq_qspi_child_pre_probe, >> }; >> -- >> 1.7.1 > > > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. >
On 29 June 2016 at 00:03, Jagan Teki <jagannadh.teki@gmail.com> wrote: > On 21 June 2016 at 17:24, Siva Durga Prasad Paladugu > <siva.durga.paladugu@xilinx.com> wrote: >> Hi Tom, >> >>> -----Original Message----- >>> From: Siva Durga Prasad Paladugu >>> Sent: Tuesday, June 14, 2016 2:49 PM >>> To: u-boot@lists.denx.de; jagannadh.teki@gmail.com >>> Cc: Michal Simek <michals@xilinx.com>; 'Siva Durga Prasad Paladugu' >>> <siva.durga.paladugu@xilinx.com> >>> Subject: RE: [PATCH 1/9] spi: zynq_qspi: Add quad support for zynq qspi I couldn't find the series cover letter or I missed it, please resend the series again. thanks!
diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c index b98663c..e636244 100644 --- a/drivers/spi/zynq_qspi.c +++ b/drivers/spi/zynq_qspi.c @@ -11,7 +11,9 @@ #include <dm.h> #include <malloc.h> #include <spi.h> +#include <spi_flash.h> #include <asm/io.h> +#include "../mtd/spi/sf_internal.h" DECLARE_GLOBAL_DATA_PTR; @@ -156,6 +158,17 @@ static void zynq_qspi_init_hw(struct zynq_qspi_priv *priv) writel(ZYNQ_QSPI_ENR_SPI_EN_MASK, ®s->enr); } +static int zynq_qspi_child_pre_probe(struct udevice *bus) +{ + struct spi_slave *slave = dev_get_parent_priv(bus); + + slave->mode_rx = QUAD_OUTPUT_FAST; + slave->mode = SPI_TX_QUAD; + slave->no_all_quad = 1; + + return 0; +} + static int zynq_qspi_probe(struct udevice *bus) { struct zynq_qspi_platdata *plat = dev_get_platdata(bus); @@ -627,4 +640,5 @@ U_BOOT_DRIVER(zynq_qspi) = { .platdata_auto_alloc_size = sizeof(struct zynq_qspi_platdata), .priv_auto_alloc_size = sizeof(struct zynq_qspi_priv), .probe = zynq_qspi_probe, + .child_pre_probe = zynq_qspi_child_pre_probe, };
Add quad commands supports for zynq qspi driver Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> --- - Tested on zc702 board --- drivers/spi/zynq_qspi.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)