Patchwork [12/14] size_t is unsigned, so (foo >= 0) is always true

login
register
mail settings
Submitter Jes Sorensen
Date Aug. 30, 2010, 3:35 p.m.
Message ID <1283182547-26116-13-git-send-email-Jes.Sorensen@redhat.com>
Download mbox | patch
Permalink /patch/63069/
State New
Headers show

Comments

Jes Sorensen - Aug. 30, 2010, 3:35 p.m.
From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 ui/vnc-enc-tight.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index c4c9c3b..df975af 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -926,7 +926,7 @@  static int send_full_color_rect(VncState *vs, int x, int y, int w, int h)
                                 tight_conf[vs->tight.compression].raw_zlib_level,
                                 Z_DEFAULT_STRATEGY);
 
-    return (bytes >= 0);
+    return 1;
 }
 
 static int send_solid_rect(VncState *vs)
@@ -1001,7 +1001,7 @@  static int send_mono_rect(VncState *vs, int x, int y,
     vs->tight.tight.offset = bytes;
 
     bytes = tight_compress_data(vs, stream, bytes, level, Z_DEFAULT_STRATEGY);
-    return (bytes >= 0);
+    return 1;
 }
 
 struct palette_cb_priv {
@@ -1057,7 +1057,7 @@  static bool send_gradient_rect(VncState *vs, int x, int y, int w, int h)
 
     bytes = tight_compress_data(vs, stream, bytes,
                                 level, Z_FILTERED);
-    return (bytes >= 0);
+    return 1;
 }
 
 static int send_palette_rect(VncState *vs, int x, int y,
@@ -1118,7 +1118,7 @@  static int send_palette_rect(VncState *vs, int x, int y,
 
     bytes = tight_compress_data(vs, stream, bytes,
                                 level, Z_DEFAULT_STRATEGY);
-    return (bytes >= 0);
+    return 1;
 }
 
 #if defined(CONFIG_VNC_JPEG) || defined(CONFIG_VNC_PNG)