| Submitter | Kyle Moffett |
|---|---|
| Date | Aug. 30, 2010, 3:38 p.m. |
| Message ID | <1283182719-4621-1-git-send-email-Kyle.D.Moffett@boeing.com> |
| Download | mbox | patch |
| Permalink | /patch/63052/ |
| State | Not Applicable |
| Headers | show |
Comments
On 30.08.2010, at 17:38, Kyle Moffett wrote: > The kvmppc_e500_stlbe_invalidate() function was trying to pass too many > parameters to trace_kvm_stlb_inval(). This appears to be a bad > copy-paste from a call to trace_kvm_stlb_write(). > > Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com> Thanks, applied. Alex
Patch
diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch/powerpc/kvm/e500_tlb.c index 66845a5..a413883 100644 --- a/arch/powerpc/kvm/e500_tlb.c +++ b/arch/powerpc/kvm/e500_tlb.c @@ -226,11 +226,7 @@ static void kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500, kvmppc_e500_shadow_release(vcpu_e500, tlbsel, esel); stlbe->mas1 = 0; - /* XXX doesn't compile */ -#if 0 - trace_kvm_stlb_inval(index_of(tlbsel, esel), stlbe->mas1, stlbe->mas2, - stlbe->mas3, stlbe->mas7); -#endif + trace_kvm_stlb_inval(index_of(tlbsel, esel)); } static void kvmppc_e500_tlb1_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,
The kvmppc_e500_stlbe_invalidate() function was trying to pass too many parameters to trace_kvm_stlb_inval(). This appears to be a bad copy-paste from a call to trace_kvm_stlb_write(). Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com> --- Alex, This is the rebased patch to re-enable the tracepoint. I also pushed a tree with this patch on top of kvm-ppc-next out to: git://opensource.exmeritus.com/hww-1u-1a/linux.git kvm-ppc-patches http://opensource.exmeritus.com/git/hww-1u-1a/linux.git/kvm-ppc-patches Thanks again! Cheers, Kyle Moffett --- arch/powerpc/kvm/e500_tlb.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)