From patchwork Wed Oct 29 20:05:14 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 6304 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CFC29DDDF0 for ; Thu, 30 Oct 2008 07:05:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbYJ2UFU (ORCPT ); Wed, 29 Oct 2008 16:05:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753358AbYJ2UFT (ORCPT ); Wed, 29 Oct 2008 16:05:19 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:46139 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753356AbYJ2UFR (ORCPT ); Wed, 29 Oct 2008 16:05:17 -0400 Received: from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi [128.214.166.179]) (AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by mail.cs.helsinki.fi with esmtp; Wed, 29 Oct 2008 22:05:15 +0200 id 0005BECB.4908C1FB.00002179 Received: by wrl-59.cs.helsinki.fi (Postfix, from userid 50795) id D09A9A009F; Wed, 29 Oct 2008 22:05:15 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by wrl-59.cs.helsinki.fi (Postfix) with ESMTP id CDC58A0098; Wed, 29 Oct 2008 22:05:15 +0200 (EET) Date: Wed, 29 Oct 2008 22:05:14 +0200 (EET) From: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" X-X-Sender: ijjarvin@wrl-59.cs.helsinki.fi To: David Miller cc: Netdev , marcel@holtmann.org Subject: [PATCH] bpa10x: free sk_buff with kfree_skb In-Reply-To: <20081026.232626.97216182.davem@davemloft.net> Message-ID: References: <20081026.232626.97216182.davem@davemloft.net> MIME-Version: 1.0 Content-ID: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 26 Oct 2008, David Miller wrote: > 2) Couple places trying to pass sk_buff to kfree() instead of > kfree_skb(). Fixed by Sergio Luis I tried with coccinelle and found one more of these, though my other attempts with it haven't been all that successful... Acked-by: Marcel Holtmann --- [PATCH] bpa10x: free sk_buff with kfree_skb Inspired by Sergio Luis' similar patches, I finally found a case which is trivial enough that spatch won't choke on it. Signed-off-by: Ilpo Järvinen --- drivers/bluetooth/bpa10x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c index 32f3a8e..b936d8c 100644 --- a/drivers/bluetooth/bpa10x.c +++ b/drivers/bluetooth/bpa10x.c @@ -443,8 +443,8 @@ static void bpa10x_destruct(struct hci_dev *hdev) BT_DBG("%s", hdev->name); - kfree(data->rx_skb[0]); - kfree(data->rx_skb[1]); + kfree_skb(data->rx_skb[0]); + kfree_skb(data->rx_skb[1]); kfree(data); }