Patchwork [fortran] Dependencies for frontend-passes.c

login
register
mail settings
Submitter FX
Date Aug. 30, 2010, 10:54 a.m.
Message ID <DCBF1CB5-172C-4342-AD26-3AF693EB016B@gmail.com>
Download mbox | patch
Permalink /patch/63017/
State New
Headers show

Comments

FX - Aug. 30, 2010, 10:54 a.m.
> I have two testsuite failures on x86_64-darwin: trim_optimize_1.f90 and widechar_intrinsics_5.f90. I don't know how they could possibly be related, but my baseline testsuite run is still running.

Now I understand why I had these failures... When the file frontend-passes.c was added to the Fortran front-end, its dependencies were not clearly indicated in Make-lang.in... not even its dependency on gfortran.h, which is rather annoying and can get build in mixed states (in my case, frontend-passes.c values for intrinsic symbol IDs were off by one due to the introduction of the new EXECUTE_COMMAND_LINE in my patch).

So, I propose the following patch:

2010-08-30  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>

	* Make-lang.in: Add frontend-passes.o dependencies.


Built on x64_64-linux. OK to commit?

FX
Tobias Burnus - Aug. 30, 2010, 11:38 a.m.
On 08/30/2010 12:54 PM, FX wrote:
> 2010-08-30  Francois-Xavier Coudert<fxcoudert@gcc.gnu.org>
>
> 	* Make-lang.in: Add frontend-passes.o dependencies.
>
>
> Built on x64_64-linux. OK to commit?

OK. Sorry for missing it in the initial review.

Tobias
Thomas Koenig - Aug. 30, 2010, 5:30 p.m.
Am Montag, den 30.08.2010, 13:38 +0200 schrieb Tobias Burnus:
> On 08/30/2010 12:54 PM, FX wrote:
> > 2010-08-30  Francois-Xavier Coudert<fxcoudert@gcc.gnu.org>
> >
> > 	* Make-lang.in: Add frontend-passes.o dependencies.
> >
> >
> > Built on x64_64-linux. OK to commit?
> 
> OK. Sorry for missing it in the initial review.

Thanks for fixing this, and sorry for missing this in the first place.

	Thomas

Patch

Index: Make-lang.in
===================================================================
--- Make-lang.in	(revision 163620)
+++ Make-lang.in	(working copy)
@@ -339,6 +339,7 @@ 
   libfuncs.h expr.h
 fortran/scanner.o: toplev.h fortran/cpp.h
 fortran/convert.o: $(GFORTRAN_TRANS_DEPS)
+fortran/frontend-passes.o: $(GFORTRAN_TRANS_DEPS)
 fortran/trans.o: $(GFORTRAN_TRANS_DEPS) tree-iterator.h
 fortran/trans-decl.o: $(GFORTRAN_TRANS_DEPS) gt-fortran-trans-decl.h \
   $(CGRAPH_H) $(TARGET_H) $(FUNCTION_H) $(FLAGS_H) $(RTL_H) $(GIMPLE_H) \