diff mbox

pxa168_eth: fix a mdiobus leak

Message ID 20100830072138.GA8797@hera.kernel.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Denis Kirjanov Aug. 30, 2010, 7:21 a.m. UTC 
mdiobus resources must be released on exit
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
---
 drivers/net/pxa168_eth.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Dan Carpenter Aug. 30, 2010, 8:47 a.m. UTC | #1 
On Mon, Aug 30, 2010 at 07:21:38AM +0000, Denis Kirjanov wrote:
> mdiobus resources must be released on exit
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

Acked-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Sept. 1, 2010, 9:30 p.m. UTC | #2 
From: Denis Kirjanov <dkirjanov@kernel.org>
Date: Mon, 30 Aug 2010 07:21:38 +0000

> mdiobus resources must be released on exit
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
index 410ea0a..85eddda 100644
--- a/drivers/net/pxa168_eth.c
+++ b/drivers/net/pxa168_eth.c
@@ -1606,6 +1606,8 @@  static int pxa168_eth_remove(struct platform_device *pdev)
 
 	iounmap(pep->base);
 	pep->base = NULL;
+	mdiobus_unregister(pep->smi_bus);
+	mdiobus_free(pep->smi_bus);
 	unregister_netdev(dev);
 	flush_scheduled_work();
 	free_netdev(dev);