| Message ID | 1464972256-10408-4-git-send-email-andrew@lunn.ch |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The DSA layer should no longer assume the switch is connected to an > MDIO bus. As a result, we cannot use the address on the MDIO bus when > forming the name of the switches internal MDIO bus for its builtin and > possibly external PHYs. The switch index is sufficient to make the > name unique, so drop the MDIO address. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Andrew Lunn <andrew@lunn.ch> writes: > The DSA layer should no longer assume the switch is connected to an > MDIO bus. As a result, we cannot use the address on the MDIO bus when > forming the name of the switches internal MDIO bus for its builtin and > possibly external PHYs. The switch index is sufficient to make the > name unique, so drop the MDIO address. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 135a91706755..f640a48a6ff3 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -49,8 +49,7 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds) ds->slave_mii_bus->name = "dsa slave smi"; ds->slave_mii_bus->read = dsa_slave_phy_read; ds->slave_mii_bus->write = dsa_slave_phy_write; - snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d:%.2x", - ds->index, ds->cd->sw_addr); + snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d", ds->index); ds->slave_mii_bus->parent = ds->dev; ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask; }
The DSA layer should no longer assume the switch is connected to an MDIO bus. As a result, we cannot use the address on the MDIO bus when forming the name of the switches internal MDIO bus for its builtin and possibly external PHYs. The switch index is sufficient to make the name unique, so drop the MDIO address. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- net/dsa/slave.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)