Patchwork PATCH: Replace | with || in TARGET_HAS_SINCOS

login
register
mail settings
Submitter H.J. Lu
Date Aug. 30, 2010, 12:37 a.m.
Message ID <20100830003754.GA27228@intel.com>
Download mbox | patch
Permalink /patch/62982/
State New
Headers show

Comments

H.J. Lu - Aug. 30, 2010, 12:37 a.m.
Hi,

Is there a reason to use | instead of || in TARGET_HAS_SINCOS? This
patch replaces | with ||.  OK for trunk?

Thanks.


H.J.
---
2010-08-29  H.J. Lu  <hongjiu.lu@intel.com>

	* config/linux.h (TARGET_HAS_SINCOS): Replace | with ||.
Maxim Kuvyrkov - Aug. 30, 2010, 7:24 a.m.
On 8/30/10 4:37 AM, H.J. Lu wrote:
> Hi,
>
> Is there a reason to use | instead of || in TARGET_HAS_SINCOS?

It's a typo.

> This
> patch replaces | with ||.  OK for trunk?

IMO, you can check it in under an obvious/typo rule.

Thanks,
H.J. Lu - Aug. 30, 2010, 1:20 p.m.
On Mon, Aug 30, 2010 at 12:24 AM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
> On 8/30/10 4:37 AM, H.J. Lu wrote:
>>
>> Hi,
>>
>> Is there a reason to use | instead of || in TARGET_HAS_SINCOS?
>
> It's a typo.
>
>> This
>> patch replaces | with ||.  OK for trunk?
>
> IMO, you can check it in under an obvious/typo rule.
>

I checked it in.

Thanks.

Patch

diff --git a/gcc/config/linux.h b/gcc/config/linux.h
index e283a9a..7c0ca95 100644
--- a/gcc/config/linux.h
+++ b/gcc/config/linux.h
@@ -160,6 +160,6 @@  see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #define TARGET_C99_FUNCTIONS (OPTION_GLIBC)
 
 /* Whether we have sincos that follows the GNU extension.  */
-#define TARGET_HAS_SINCOS (OPTION_GLIBC | OPTION_BIONIC)
+#define TARGET_HAS_SINCOS (OPTION_GLIBC || OPTION_BIONIC)
 
 #define TARGET_POSIX_IO