diff mbox

[U-Boot,v2,4/5] armv8/ls2080: Remove workaround for erratum A008751

Message ID 1464850458-2850-5-git-send-email-sriram.dash@nxp.com
State Superseded
Delegated to: Marek Vasut
Headers show

Commit Message

Sriram Dash June 2, 2016, 6:54 a.m. UTC 
Remove the errata workaround from soc specific file for LS2080

Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
Changes in v2:
  - No update


 arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Marek Vasut June 2, 2016, 12:57 p.m. UTC | #1 
On 06/02/2016 08:54 AM, Sriram Dash wrote:
> Remove the errata workaround from soc specific file for LS2080

The commit message does not explain why this change is legal or needed.

> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> ---
> Changes in v2:
>   - No update
> 
> 
>  arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> index 0fb5c7f..5636531 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> @@ -122,15 +122,6 @@ void erratum_a009635(void)
>  }
>  #endif	/* CONFIG_SYS_FSL_ERRATUM_A009635 */
>  
> -static void erratum_a008751(void)
> -{
> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008751
> -	u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE;
> -
> -	writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4);
> -#endif
> -}
> -
>  static void erratum_rcw_src(void)
>  {
>  #if defined(CONFIG_SPL)
> @@ -187,7 +178,6 @@ void bypass_smmu(void)
>  }
>  void fsl_lsch3_early_init_f(void)
>  {
> -	erratum_a008751();
>  	erratum_rcw_src();
>  	init_early_memctl_regs();	/* tighten IFC timing */
>  	erratum_a009203();
>
Sriram Dash June 6, 2016, 4:23 a.m. UTC | #2 
>-----Original Message-----
>From: Marek Vasut [mailto:marex@denx.de]
>Sent: Thursday, June 02, 2016 6:28 PM
>To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de
>Cc: york sun <york.sun@nxp.com>; albert.u.boot@aribaud.net; Rajesh Bhagat
><rajesh.bhagat@nxp.com>
>Subject: Re: [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum
>A008751
>
>On 06/02/2016 08:54 AM, Sriram Dash wrote:
>> Remove the errata workaround from soc specific file for LS2080
>
>The commit message does not explain why this change is legal or needed.
>

This errata a008751 is applied on Soc specific file currently.
We are moving this errata to a a file where all the errata implementation will take Place for usb for fsl. Implementation of the errata will follow in Patch 5/5.

However, I cannot reference to the driver specific implementation till it is committed.
So, this is just the description of removing the errata from soc specific file.

>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>> ---
>> Changes in v2:
>>   - No update
>>
>>
>>  arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> index 0fb5c7f..5636531 100644
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>> @@ -122,15 +122,6 @@ void erratum_a009635(void)  }
>>  #endif	/* CONFIG_SYS_FSL_ERRATUM_A009635 */
>>
>> -static void erratum_a008751(void)
>> -{
>> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008751
>> -	u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE;
>> -
>> -	writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4);
>> -#endif
>> -}
>> -
>>  static void erratum_rcw_src(void)
>>  {
>>  #if defined(CONFIG_SPL)
>> @@ -187,7 +178,6 @@ void bypass_smmu(void)  }  void
>> fsl_lsch3_early_init_f(void)  {
>> -	erratum_a008751();
>>  	erratum_rcw_src();
>>  	init_early_memctl_regs();	/* tighten IFC timing */
>>  	erratum_a009203();
>>
>
>
>--
>Best regards,
>Marek Vasut
Marek Vasut June 6, 2016, 12:25 p.m. UTC | #3 
On 06/06/2016 06:23 AM, Sriram Dash wrote:
>> -----Original Message-----
>> From: Marek Vasut [mailto:marex@denx.de]
>> Sent: Thursday, June 02, 2016 6:28 PM
>> To: Sriram Dash <sriram.dash@nxp.com>; u-boot@lists.denx.de
>> Cc: york sun <york.sun@nxp.com>; albert.u.boot@aribaud.net; Rajesh Bhagat
>> <rajesh.bhagat@nxp.com>
>> Subject: Re: [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum
>> A008751
>>
>> On 06/02/2016 08:54 AM, Sriram Dash wrote:
>>> Remove the errata workaround from soc specific file for LS2080
>>
>> The commit message does not explain why this change is legal or needed.
>>
> 
> This errata a008751 is applied on Soc specific file currently.
> We are moving this errata to a a file where all the errata implementation will take Place for usb for fsl. Implementation of the errata will follow in Patch 5/5.
> 
> However, I cannot reference to the driver specific implementation till it is committed.
> So, this is just the description of removing the errata from soc specific file.

This explanation should be in the commit message.

>>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>>> ---
>>> Changes in v2:
>>>   - No update
>>>
>>>
>>>  arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ----------
>>>  1 file changed, 10 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> index 0fb5c7f..5636531 100644
>>> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> @@ -122,15 +122,6 @@ void erratum_a009635(void)  }
>>>  #endif	/* CONFIG_SYS_FSL_ERRATUM_A009635 */
>>>
>>> -static void erratum_a008751(void)
>>> -{
>>> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008751
>>> -	u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE;
>>> -
>>> -	writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4);
>>> -#endif
>>> -}
>>> -
>>>  static void erratum_rcw_src(void)
>>>  {
>>>  #if defined(CONFIG_SPL)
>>> @@ -187,7 +178,6 @@ void bypass_smmu(void)  }  void
>>> fsl_lsch3_early_init_f(void)  {
>>> -	erratum_a008751();
>>>  	erratum_rcw_src();
>>>  	init_early_memctl_regs();	/* tighten IFC timing */
>>>  	erratum_a009203();
>>>
>>
>>
>> --
>> Best regards,
>> Marek Vasut
diff mbox

Patch

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
index 0fb5c7f..5636531 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
@@ -122,15 +122,6 @@  void erratum_a009635(void)
 }
 #endif	/* CONFIG_SYS_FSL_ERRATUM_A009635 */
 
-static void erratum_a008751(void)
-{
-#ifdef CONFIG_SYS_FSL_ERRATUM_A008751
-	u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE;
-
-	writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4);
-#endif
-}
-
 static void erratum_rcw_src(void)
 {
 #if defined(CONFIG_SPL)
@@ -187,7 +178,6 @@  void bypass_smmu(void)
 }
 void fsl_lsch3_early_init_f(void)
 {
-	erratum_a008751();
 	erratum_rcw_src();
 	init_early_memctl_regs();	/* tighten IFC timing */
 	erratum_a009203();