From patchwork Sat Aug 28 02:41:56 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 62888 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F1FCBB7110 for ; Sat, 28 Aug 2010 12:48:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016Ab0H1Csu (ORCPT ); Fri, 27 Aug 2010 22:48:50 -0400 Received: from mail-px0-f174.google.com ([209.85.212.174]:38823 "EHLO mail-px0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378Ab0H1Css (ORCPT ); Fri, 27 Aug 2010 22:48:48 -0400 Received: by pxi10 with SMTP id 10so1300561pxi.19 for ; Fri, 27 Aug 2010 19:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=pQBWGIGMoYn/21iSx0UzbuF4rrwacbbYrS2F1W7+tbw=; b=vX7evWvP1DlWRjWEsILlHErf8PdzKdKeBTNrzSiqqwOUnhqbC9CJo2iRHXrIpdLOM7 mQfBqRjefHa0Gp4/8qvMTcoMVXkWe/MqU1ozfO5paZKnEA51+uPgW91AcaYPU8PdVogt Eq+b0GuSEvUP3ONlB8KSsdHNXs8nKt24C4ENY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=dYYDC9IMaTnxcbHL6ePTAShkZaYcom6cgADvhxBHmuCi61itRs7/yb/3TF7gASUMJn aEDTQ6HyneKJb2K0GRVuLJuZdayEwfPB2pz0jc4xuy6KD3DKU5CxeQhxwMVU1LeFLH53 ALExkeYZkuWuKDoNRvfFpvE6uu30IoLLKhWuc= Received: by 10.114.161.20 with SMTP id j20mr1443132wae.167.1282963728459; Fri, 27 Aug 2010 19:48:48 -0700 (PDT) Received: from localhost (p17219-adsau04yokonib3-acca.kanagawa.ocn.ne.jp [60.43.121.219]) by mx.google.com with ESMTPS id c10sm7897804wam.1.2010.08.27.19.48.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Aug 2010 19:48:47 -0700 (PDT) From: Akinobu Mita To: kernel-janitors@vger.kernel.org Cc: Akinobu Mita , Julia Lawall , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH] econet: kill unnecessary spin_lock_init() Date: Sat, 28 Aug 2010 11:41:56 +0900 Message-Id: <1282963316-29938-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.6.0.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The spinlock aun_queue_lock is initialized statically. It is unnecessary to initialize by spin_lock_init() at module load time. This is detected by the semantic patch. // @def@ declarer name DEFINE_SPINLOCK; identifier spinlock; @@ DEFINE_SPINLOCK(spinlock); @@ identifier def.spinlock; @@ - spin_lock_init(&spinlock); // Signed-off-by: Akinobu Mita Cc: Julia Lawall Cc: "David S. Miller" Cc: netdev@vger.kernel.org --- net/econet/af_econet.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index dc54bd0..baa98fb 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -1009,7 +1009,6 @@ static int __init aun_udp_initialise(void) struct sockaddr_in sin; skb_queue_head_init(&aun_queue); - spin_lock_init(&aun_queue_lock); setup_timer(&ab_cleanup_timer, ab_cleanup, 0); ab_cleanup_timer.expires = jiffies + (HZ*2); add_timer(&ab_cleanup_timer); @@ -1167,7 +1166,6 @@ static int __init econet_proto_init(void) goto out; sock_register(&econet_family_ops); #ifdef CONFIG_ECONET_AUNUDP - spin_lock_init(&aun_queue_lock); aun_udp_initialise(); #endif #ifdef CONFIG_ECONET_NATIVE