Patchwork econet: kill unnecessary spin_lock_init()

login
register
mail settings
Submitter Akinobu Mita
Date Aug. 28, 2010, 2:41 a.m.
Message ID <1282963316-29938-1-git-send-email-akinobu.mita@gmail.com>
Download mbox | patch
Permalink /patch/62888/
State Accepted
Delegated to: David Miller
Headers show

Comments

Akinobu Mita - Aug. 28, 2010, 2:41 a.m.
The spinlock aun_queue_lock is initialized statically. It is unnecessary
to initialize by spin_lock_init() at module load time.

This is detected by the semantic patch.

// <smpl>
@def@
declarer name DEFINE_SPINLOCK;
identifier spinlock;
@@

DEFINE_SPINLOCK(spinlock);

@@
identifier def.spinlock;
@@

- spin_lock_init(&spinlock);
// </smpl>

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
 net/econet/af_econet.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
David Miller - Aug. 28, 2010, 10:37 p.m.
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: Sat, 28 Aug 2010 11:41:56 +0900

> The spinlock aun_queue_lock is initialized statically. It is unnecessary
> to initialize by spin_lock_init() at module load time.
> 
> This is detected by the semantic patch.
 ...
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Julia Lawall <julia@diku.dk>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index dc54bd0..baa98fb 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -1009,7 +1009,6 @@  static int __init aun_udp_initialise(void)
 	struct sockaddr_in sin;
 
 	skb_queue_head_init(&aun_queue);
-	spin_lock_init(&aun_queue_lock);
 	setup_timer(&ab_cleanup_timer, ab_cleanup, 0);
 	ab_cleanup_timer.expires = jiffies + (HZ*2);
 	add_timer(&ab_cleanup_timer);
@@ -1167,7 +1166,6 @@  static int __init econet_proto_init(void)
 		goto out;
 	sock_register(&econet_family_ops);
 #ifdef CONFIG_ECONET_AUNUDP
-	spin_lock_init(&aun_queue_lock);
 	aun_udp_initialise();
 #endif
 #ifdef CONFIG_ECONET_NATIVE