| Message ID | 1464794983-31484-3-git-send-email-l.stach@pengutronix.de |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > @@ -97,6 +97,7 @@ > phy-reset-gpios = <&gpio3 31 0>; > interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > + fsl,err006687-war-present; war? Any reason not to spell it out, or use the more natural abbreviation "wa"?
Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM Linux: > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > @@ -97,6 +97,7 @@ > > phy-reset-gpios = <&gpio3 31 0>; > > interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > > + fsl,err006687-war-present; > > war? Any reason not to spell it out, or use the more natural > abbreviation "wa"? > Apparently I've read too many documents where WAR is the abbreviation for workaround, so it felt completely natural to me. I agree that it would make sense to just spell it out to avoid any confusion. Regards, Lucas
On Thu, 02 Jun 2016 10:25:06 +0200 Lucas Stach <l.stach@pengutronix.de> wrote: > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM > Linux: > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > > @@ -97,6 +97,7 @@ > > > phy-reset-gpios = <&gpio3 31 0>; > > > interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > > > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > > > + fsl,err006687-war-present; > > Why can't we just have the quirk detect the interrupts-extended property, which is not present on boards without the workaround. Wouldn't that be better? No dts change needed. > > war? Any reason not to spell it out, or use the more natural > > abbreviation "wa"? > > > Apparently I've read too many documents where WAR is the abbreviation > for workaround, so it felt completely natural to me. I agree that it > would make sense to just spell it out to avoid any confusion. > > Regards, > Lucas > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Am Dienstag, den 07.06.2016, 12:46 -0700 schrieb Joshua Clayton: > On Thu, 02 Jun 2016 10:25:06 +0200 > Lucas Stach <l.stach@pengutronix.de> wrote: > > > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM > > Linux: > > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote: > > > > @@ -97,6 +97,7 @@ > > > > phy-reset-gpios = <&gpio3 31 0>; > > > > interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > > > > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > > > > + fsl,err006687-war-present; > > > > > Why can't we just have the quirk detect the interrupts-extended > property, which is not present on boards without the workaround. > Wouldn't that be better? No dts change needed. > I pondered that idea too, but have gone with the solution presented in this patch series as it's more explicit and - with far more weight to it - does not require the driver to touch DT properties that are outside of its domain of responsibility. The "interrupts-extended" properties are not meant to be parsed by the driver, but rather the IRQ subsystem. Regards, Lucas
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts index bfbed52ce1bd..b10dc9513c6b 100644 --- a/arch/arm/boot/dts/imx6dl-riotboard.dts +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts @@ -97,6 +97,7 @@ phy-reset-gpios = <&gpio3 31 0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6q-arm2.dts b/arch/arm/boot/dts/imx6q-arm2.dts index d6515f7a56c4..fce60ef991ce 100644 --- a/arch/arm/boot/dts/imx6q-arm2.dts +++ b/arch/arm/boot/dts/imx6q-arm2.dts @@ -185,6 +185,7 @@ phy-mode = "rgmii"; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi b/arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi index e456b5cc1b03..a74f396965ca 100644 --- a/arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi @@ -250,6 +250,7 @@ txd3-skew-ps = <0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi index 657da6b6ccd2..da76a128e5a9 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi @@ -385,6 +385,7 @@ txd3-skew-ps = <0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi index 73915db704a0..dfcb5001a126 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi @@ -287,6 +287,7 @@ txd3-skew-ps = <0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index d354d406954d..e250da2a4caa 100644 --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi @@ -155,6 +155,7 @@ phy-mode = "rgmii"; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi index c47fe6c79b36..d451ca242751 100644 --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi @@ -273,6 +273,7 @@ txd3-skew-ps = <0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi index 8e7c40e114dd..684c6a776565 100644 --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi @@ -211,6 +211,7 @@ phy-reset-gpios = <&gpio3 29 0>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + fsl,err006687-war-present; status = "okay"; };
Add the DT property to all boards that have the hardware workaround for erratum ERR006687 present. This allows the CPUidle driver to use the deep idle states, even if the FEC is active. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm/boot/dts/imx6dl-riotboard.dts | 1 + arch/arm/boot/dts/imx6q-arm2.dts | 1 + arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi | 1 + arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 1 + arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 1 + arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 1 + arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 1 + arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 1 + 8 files changed, 8 insertions(+)