| Message ID | 1464693198-16523-2-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Rejected |
| Headers | show |
Vicente, All, On 2016-05-31 12:13 +0100, Vicente Olivert Riera spake thusly: > As stated here [1], recent changes on the MIPS binutils sources have > made it necessary for GCC to pass the -msoft-float to the assembler. Due > to that, valgrind fails to build for MIPS soft-float when using a > version of GCC >= 4.9 and binutils >= 2.25 because its using some > hard-float instructions. The combination of GCC-4.8.x and binutils >= > 2.25 is not possible as its disabled in package/gcc/Config.in.host. > > 1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html > > Fixes: > http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/ > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > package/valgrind/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in > index 21b2608..3093809 100644 > --- a/package/valgrind/Config.in > +++ b/package/valgrind/Config.in > @@ -8,6 +8,7 @@ config BR2_PACKAGE_VALGRIND > BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \ > BR2_x86_64 > depends on !BR2_STATIC_LIBS > + depends on !(BR2_MIPS_SOFT_FLOAT && BR2_TOOLCHAIN_BINUTILS_AT_LEAST_2_25) Your commit log talks about the combination of gcc >= 4.8 *with* binutils >= 2.25. However, here, you only hide for binutils >= 2.25. And we still have gcc-4.7 (albeit deprecated). Is it known broken with the gcc-4.7 and binutils >= 2.25 combination too? So, except for this deprecated gcc-4.7, what matters is only the binutils version. There is no need to talk about the gcc version in the commit log (except maybe to state taht we don't care about the deprecated gcc-4.7). Otherwise: Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > help > Tool for debugging and profiling Linux programs. > > -- > 2.7.3 >
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in index 21b2608..3093809 100644 --- a/package/valgrind/Config.in +++ b/package/valgrind/Config.in @@ -8,6 +8,7 @@ config BR2_PACKAGE_VALGRIND BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \ BR2_x86_64 depends on !BR2_STATIC_LIBS + depends on !(BR2_MIPS_SOFT_FLOAT && BR2_TOOLCHAIN_BINUTILS_AT_LEAST_2_25) help Tool for debugging and profiling Linux programs.
As stated here [1], recent changes on the MIPS binutils sources have made it necessary for GCC to pass the -msoft-float to the assembler. Due to that, valgrind fails to build for MIPS soft-float when using a version of GCC >= 4.9 and binutils >= 2.25 because its using some hard-float instructions. The combination of GCC-4.8.x and binutils >= 2.25 is not possible as its disabled in package/gcc/Config.in.host. 1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html Fixes: http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/ Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/valgrind/Config.in | 1 + 1 file changed, 1 insertion(+)