From patchwork Thu Aug 26 16:29:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 62786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 79993B70DD for ; Fri, 27 Aug 2010 02:35:39 +1000 (EST) Received: from localhost ([127.0.0.1]:44283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OofQO-000666-6o for incoming@patchwork.ozlabs.org; Thu, 26 Aug 2010 12:35:36 -0400 Received: from [140.186.70.92] (port=55640 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OofKT-0003ht-Dl for qemu-devel@nongnu.org; Thu, 26 Aug 2010 12:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OofKQ-00062I-N5 for qemu-devel@nongnu.org; Thu, 26 Aug 2010 12:29:29 -0400 Received: from cantor.suse.de ([195.135.220.2]:41056 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OofKQ-00061f-FF for qemu-devel@nongnu.org; Thu, 26 Aug 2010 12:29:26 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 1C0449F8E4; Thu, 26 Aug 2010 18:29:24 +0200 (CEST) From: Alexander Graf To: qemu-devel List Date: Thu, 26 Aug 2010 18:29:21 +0200 Message-Id: <1282840163-2223-5-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1282840163-2223-1-git-send-email-agraf@suse.de> References: <1282840163-2223-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Hollis Blanchard Subject: [Qemu-devel] [PATCH 4/6] ppc4xx: correct SDRAM controller warning message condition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Hollis Blanchard The message "Truncating memory to %d MiB to fit SDRAM controller limits" should be displayed only when a user chooses an amount of RAM which can't be represented by the PPC 4xx SDRAM controller (e.g. 129MB, which would only be valid if the controller supports a bank size of 1MB). Signed-off-by: Hollis Blanchard --- hw/ppc4xx_devs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppc4xx_devs.c b/hw/ppc4xx_devs.c index b15db81..be130c4 100644 --- a/hw/ppc4xx_devs.c +++ b/hw/ppc4xx_devs.c @@ -684,7 +684,7 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, } ram_size -= size_left; - if (ram_size) + if (size_left) printf("Truncating memory to %d MiB to fit SDRAM controller limits.\n", (int)(ram_size >> 20));