| Message ID | 1464553500-19043-1-git-send-email-ykaneko0929@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On 05/29/2016 11:25 PM, Yoshihiro Kaneko wrote: > From: Masaru Nagai <masaru.nagai.vx@renesas.com> > > This patch adds enabling separation filter(ESF) is setting value of B'11. > This setting filter for separating AVB stream frames from non-AVB stream > frames is enabled. Non-matching frames from a stream are processed in > queue 0(best effort). H/W manual recommends B'11 or B'10. > When B'10 is setting, Non-mating frames are discarded. It was somewhat hard for me to parse that... > Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
On 05/30/2016 05:30 PM, Sergei Shtylyov wrote: >> From: Masaru Nagai <masaru.nagai.vx@renesas.com> >> >> This patch adds enabling separation filter(ESF) is setting value of B'11. >> This setting filter for separating AVB stream frames from non-AVB stream >> frames is enabled. Non-matching frames from a stream are processed in >> queue 0(best effort). H/W manual recommends B'11 or B'10. >> When B'10 is setting, Non-mating frames are discarded. > > It was somewhat hard for me to parse that... Forgot about s/Non-mating/Non-matching/. >> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com> >> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
Hi Sergei, 2016-05-31 6:19 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>: > On 05/30/2016 05:30 PM, Sergei Shtylyov wrote: > >>> From: Masaru Nagai <masaru.nagai.vx@renesas.com> >>> >>> This patch adds enabling separation filter(ESF) is setting value of B'11. >>> This setting filter for separating AVB stream frames from non-AVB stream >>> frames is enabled. Non-matching frames from a stream are processed in >>> queue 0(best effort). H/W manual recommends B'11 or B'10. >>> When B'10 is setting, Non-mating frames are discarded. >> >> >> It was somewhat hard for me to parse that... > > > Forgot about s/Non-mating/Non-matching/. Thanks for your review. I will revise the commit message. Thanks, kaneko > > >>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com> >>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com> >>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> >> >> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > MBR, Sergei >
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 867caf6..1ceadbf 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -402,7 +402,8 @@ static int ravb_dmac_init(struct net_device *ndev) #endif /* Set AVB RX */ - ravb_write(ndev, RCR_EFFS | RCR_ENCF | RCR_ETS0 | 0x18000000, RCR); + ravb_write(ndev, + RCR_EFFS | RCR_ENCF | RCR_ETS0 | RCR_ESF | 0x18000000, RCR); /* Set FIFO size */ ravb_write(ndev, TGC_TQP_AVBMODE1 | 0x00222200, TGC);