| Message ID | 1464361015-14755-1-git-send-email-carlosfg@riseup.net |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Fri, May 27, 2016 at 04:56:54PM +0200, Carlos Falgueras García wrote:
> All attributes are passed by copy, so user data should be copied too.
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/set_elem.c b/src/set_elem.c index 990be24..b9c7e1e 100644 --- a/src/set_elem.c +++ b/src/set_elem.c @@ -125,8 +125,14 @@ void nftnl_set_elem_set(struct nftnl_set_elem *s, uint16_t attr, s->timeout = *((uint64_t *)data); break; case NFTNL_SET_ELEM_USERDATA: /* NFTA_SET_ELEM_USERDATA */ - s->user.data = (void *)data; - s->user.len = data_len; + if (s->user.data != NULL) + xfree(s->user.data); + + s->user.data = malloc(data_len); + if (!s->user.data) + return; + memcpy(s->user.data, data, data_len); + s->user.len = data_len; break; default: return;
All attributes are passed by copy, so user data should be copied too. Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net> --- src/set_elem.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)